feat(tui): Enter interactive with i key.
#9479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
anthonyshew
commented
Nov 21, 2024
| @@ -7,8 +7,8 @@ use tui_term::widget::PseudoTerminal; | |||
|
|
|||
| use super::{app::LayoutSections, TerminalOutput}; | |||
|
|
|||
| const FOOTER_TEXT_ACTIVE: &str = "Press`Ctrl-Z` to stop interacting."; | |||
| const FOOTER_TEXT_INACTIVE: &str = "Press `Enter` to interact."; | |||
| const FOOTER_TEXT_ACTIVE: &str = "Press `Ctrl-Z` to stop interacting."; | |||
There was a problem hiding this comment.
There was a space missing!?
i key.
chris-olszewski
approved these changes
Nov 21, 2024
Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've begun to embrace the letters on the keyboard a bit more for manipulating the TUI.
This PR allows you to enter into interacting with a task using the
ikey. Notably, it leavesEnterin place, despite the helper text changing. This is to let muscle memory for existing users keep at it - until we remove it in 3.0. Hopefully they see the helper text by then.Testing Instructions
Try it out!