chore(cache): add deprecation warnings to old cache flags #9428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
anthonyshew
approved these changes
Nov 12, 2024
tknickman
reviewed
Nov 12, 2024
Comment on lines
+85
to
+88
| warn!( | ||
| "TURBO_REMOTE_ONLY is deprecated and will be removed in a future major version. \ | ||
| Use TURBO_CACHE=remote:rw" | ||
| ); |
There was a problem hiding this comment.
@anthonyshew high priority we have to set this on vercel before we ship this. I can spin this up quick
tknickman
requested changes
Nov 12, 2024
| @@ -80,7 +81,19 @@ impl ResolvedConfigurationOptions for EnvVars { | |||
|
|
|||
| let force = self.truthy_value("force").flatten(); | |||
| let remote_only = self.truthy_value("remote_only").flatten(); | |||
| if remote_only.is_some() { | |||
There was a problem hiding this comment.
Can we check for TURBO_REMOTE_ONLY and NOT TURBO_CACHE? Because we have to double set this on Vercel to get this to work without a deprecation warning
There was a problem hiding this comment.
We throw if you use legacy cache options with TURBO_CACHE:
[0 olszewski@chriss-mbp] /Users/olszewski/code/vercel/turborepo $ TURBO_REMOTE_CACHE_READ_ONLY=1 turbo_dev @turbo/types#lint --cache=remote:rw > /dev/null
WARNING No locally installed `turbo` found. Using version: 2.2.4-canary.9.
turbo 2.2.4-canary.9
WARNING TURBO_REMOTE_CACHE_READ_ONLY is deprecated and will be removed in a future major version. Use TURBO_CACHE=remote:r
x Cannot set `cache` config and other cache options (`force`, `remoteOnly`,
| `remoteCacheReadOnly`) at the same time
tknickman
approved these changes
Nov 12, 2024
This was referenced Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With introduction of
--cacheandTURBO_CACHEadd deprecation flags to the "old" cache config options.We also now will only throw on the mixing of cache env vars and
TURBO_CACHEif they do not agree. An exception isTURBO_FORCEwhich will override.Testing Instructions