chore(release): fix release by avoiding old glibc version #9464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
anthonyshew
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#9447 bumped us to
upload-artifactto v4 which uses Node 20. Node 20 required a newer glibc version than was available on our build that targeted AWS's Lambda2's glibc version. See this job for an example failure.Requiring this glibc version isn't necessary for the musl builds since it uses musl instead of glibc for libc.
I do not think this was intentional to have the musl binary building in this container as we changed this back when we were cross compiling: 8ca67c3
Future work: This does not fix the
@turbo/repositoryrelease.Testing Instructions
Ran test release and x86 msul build now passes: job