这是indexloc提供的服务,不要输入任何密码
Skip to content

Don't squash tasks with package tasks #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Mar 24, 2022

Fixes #905

Due to non-deterministic map iteration, we would squash one or the other of task definitions if we truncate package tasks to just their task name. Instead, use the full task name, with package qualifier if present, and properly pull them from the list of tasks inside the scheduler.

@vercel
Copy link

vercel bot commented Mar 24, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/744T5Sfoj1hi7VTyArf7LFtFMYbm
✅ Preview: https://turbo-site-git-gsoltis-dontsquashtasks.vercel.sh

@kodiakhq kodiakhq bot merged commit fc89d55 into main Mar 24, 2022
@kodiakhq kodiakhq bot deleted the gsoltis/dont_squash_tasks branch March 24, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specific package task definition causes nondeterministic behavior
2 participants