这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@dimitropoulos
Copy link
Contributor

@dimitropoulos dimitropoulos commented Oct 22, 2024

Description

We've been having issues with the docs link checker. It's not in a great state, so in this PR the goals are:

  • fix the problem that's been constantly failing
  • get it working to run locally (before, it only runs on PRs and will immediately fail locally if not)
  • update the tooling associated with doing this (much of it is years and years out of date).

Testing Instructions

cd docs
pnpm check-links

See failing CI run: https://github.com/vercel/turborepo/actions/runs/11467995496/job/31912111207

@turbo-orchestrator turbo-orchestrator bot added area: docs Improvements or additions to documentation area: site created-by: turborepo labels Oct 22, 2024
@vercel
Copy link
Contributor

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 5:47pm
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 5:47pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 5:47pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 5:47pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 5:47pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 5:47pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 5:47pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 5:47pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Oct 23, 2024 5:47pm

@socket-security
Copy link

socket-security bot commented Oct 22, 2024

@dimitropoulos
Copy link
Contributor Author

(note) did a final "demonstrate that the action failure works as expected" here: https://github.com/vercel/turborepo/actions/runs/11485026631/job/31964158530?pr=9311 before merging

@dimitropoulos dimitropoulos merged commit b8a54d6 into main Oct 23, 2024
44 checks passed
@dimitropoulos dimitropoulos deleted the dimitri/docs-tests branch October 23, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ci area: docs Improvements or additions to documentation area: site

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants