fix(cache): no longer let remoteCache.enable override force #9684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1 task
anthonyshew
approved these changes
Jan 11, 2025
anthonyshew
added a commit
that referenced
this pull request
Jan 13, 2025
- **docs: mention free remote caching earlier on page (#9688)** - **docs: typo fix (#9690)** - **fix(cache): no longer let remoteCache.enable override force (#9684)** - **release(turborepo): 2.3.4-canary.7 (#9692)** - **docs(fix): correct line highlighting** ### Description <!-- ✍️ Write a short summary of your work. If necessary, include relevant screenshots. --> ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9681
We were setting remote cache items to whatever the value of
remoteCache.enablewas. This incorrectly re-enabled parts of the cache that had previously been disabled. The fix is to only care if users explicitly disable remote caching, this works since ifremoteCache.enableisn't specified it is assumed to betrue.Testing Instructions
Added failing unit test in first commit, it passes after the second commit.