fix(env): allow passThroughEnv to negate built ins and globalPassThroughEnv
#9680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chris-olszewski
commented
Jan 9, 2025
| // See if we infer a framework | ||
| if let Some(framework) = infer_framework(workspace, is_monorepo) { | ||
| // See if we infer a framework | ||
| let framework = do_framework_inference |
There was a problem hiding this comment.
Previously we had if do_framework_inference { if let Some(framework) = infer_framework() { A } else { B } } else { C } where B and C were the same statements. We now merge these two outcomes to a single branch.
| @@ -242,6 +242,7 @@ pub struct TaskHasher<'a> { | |||
| hashes: HashMap<TaskId<'static>, String>, | |||
| run_opts: &'a RunOpts, | |||
| env_at_execution_start: &'a EnvironmentVariableMap, | |||
| global_env: EnvironmentVariableMap, | |||
There was a problem hiding this comment.
global_env previously lived inside of the Visitor structure. It is only used by TaskHasher so we keep it there instead of passing it in every time we construct a task's environment.
passThroughEnv to negate built ins and globalPassThroughEnv
This was referenced Jan 18, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9659
Fixing required a fair amount of code shuffling before it can be addressed. This PR is a collection of prework that I did before fixing the issue that will probably be easier to review in isolation. The final commit is the actual fix.
The important moves in the commit is moving some logic out of
TaskHasherand intoturborepo-envcrate where we can easily test this logic without constructing a fullRun.Each commit is a small incremental change to this codepath that shouldn't have any behavioral changes until the final commit.
Testing Instructions
Added unit tests for pass through env creation, existing integration tests that cover this behavior as well.
Quick manual test: