fix: respect output mode 'none' even when caching is disabled #9670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chris-olszewski
approved these changes
Jan 7, 2025
| if self.caching_disabled || self.run_cache.writes_disabled { | ||
| log_writer.with_writer(writer); | ||
| return Ok(log_writer); | ||
| if !self.caching_disabled && !self.run_cache.writes_disabled { |
There was a problem hiding this comment.
Translating this for myself: "if a task has "cache": true and is run at least one cache it can write to"
This is changed from: "if task has "cache": false or cannot write to disk"
|
|
||
| // Returning the buffer's length so callers don't think this is a failure to | ||
| // create the buffer | ||
| Ok(buf.len()) |
There was a problem hiding this comment.
Nice catch! This was dead code before so we were never hitting the bad return of Ok(0), thanks for fixing up my mistake.
Co-authored-by: Chris Olszewski <chris.olszewski@vercel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fresh PR for #7900, which sat too long and got stale. I accidentally closed the PR with no commits after force-pushing so I'm opening this for simplicity's sake.
@aholland deserves all credit here for finding this issue and proposing a fix.
Testing Instructions