这是indexloc提供的服务,不要输入任何密码
Skip to content

fix(package-manager): allow custom URL for packageManager version #9624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pkerschbaum
Copy link
Contributor

@pkerschbaum pkerschbaum commented Dec 16, 2024

Fixes #9611

Description

Field packageManager of package.json can now use a custom URL, e.g. npm@https://registry.npmjs.org/some-npm-fork/-/some-npm-fork-1.0.0.tgz

(I also fixed some minor formatting issues in CONTRIBUTING.md)

Testing Instructions

Added both an integration test and a unit test.

@turbo-orchestrator turbo-orchestrator bot added the needs: triage New issues get this label. Remove it after triage label Dec 16, 2024
Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 10:15pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 10:15pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 10:15pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 10:15pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 10:15pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 10:15pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 10:15pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 10:15pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 10:15pm

Copy link

vercel bot commented Dec 16, 2024

@pkerschbaum is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@chris-olszewski chris-olszewski enabled auto-merge (squash) December 16, 2024 22:56
@chris-olszewski chris-olszewski merged commit db580f2 into vercel:main Dec 16, 2024
35 checks passed
@pkerschbaum pkerschbaum deleted the fix/allow-url-for-packagejson-packagemanager-field branch December 17, 2024 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When a URL is used for packageManager field of package.json, an error is thrown ("expected to match regular expression")
2 participants