fix(berry): add yarn berry support for built dependencies meta when pruning #9605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anthonyshew
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A rebase of #8550 as rebasing those commits past #8813. I do not know exactly what about that change resulted in my repo getting into such a bad state, but I needed to do a fresh clone after trying to rebase past it.
From the original PR:
Add support for yarn berry built option for dependencies meta to turbo prune.
Without this change, yarn install --immutable fails because built is added after turbo accidentally removes it, triggering the following error.
All credit to @vinnymac for the original PR
Additional Changes
I added some additional unit tests and reworked the
dependenciesMetaserialization logic so it support multiple fields per dependency.Testing Instructions
Added unit test along with updating the roundtrip text fixture to include a dependency with
built: false