Stop removing unreferenced packages before task graph construction #918
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #912
In this PR:
--include-dependencies
if--scope
and--since
are both set. It should no longer be necessary.--scope
and--since
implying--include-dependencies
run
now behaves.Future work includes being able to write a test in
run_test.go
to get the whole end-to-end graph build, but we don't quite have the infrastructure for that yet (also required for follow-on work to #911)Note that this is technically a breaking change. Previously, if
a
depends onb
, and the"test"
task depends on"^build"
the following would be true:turbo run test --scope=a
would testa
but not buildb
turbo run test --scope=a --include-dependencies
would buildb
and testa
ANDb
.With this change,
turbo run test --scope=a
will now buildb
and testa
. The addition of tasks running for unselected packages is new. While this seems like more work being done, in practice I expect users to be able to move from the second example above to the first, ultimately resulting in less work being done:b#test
will no longer need to run to geta#test
to run.