这是indexloc提供的服务，不要输入任何密码

Fix invalid JSON #9109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

anthonyshew merged 1 commit into vercel:main from AlexErrant:patch-1

Sep 4, 2024

Contributor

AlexErrant commented Sep 4, 2024 •

edited

Loading

More or less a typo fix.

Also, what does "topo" mean? Searching the docs for "topo" yields nothing, and searching the repo yields

turborepo/turbo.json

Lines 215 to 219 in a8f38f1

    
           // This is a synthetic tasks that lets us pull in other workspaces as dependencies 
        
           // So changes in internal workspaces that we depend on, will trigger this task. 
        
           "topo": { 
        
             "dependsOn": ["^topo"] 
        
           }

Why should check-types depend on topo? The docs point me to "Transit Nodes", but I'm still confused. In particular,

Turborepo calls the ui package a Transit Node in this scenario, because it doesn't have its own build script.

So should we not have a topo script? If this is the case, why do other turbo.json files in this repo have a topo task (which does nothing; see below)?

Also, this repo's own check-types doesn't depend on topo. This is especially confusing when combined with this comment I found

turborepo/examples/turbo.json

Lines 3 to 6 in a8f38f1

    
           "tasks": { 
        
             // This needs to exist because upstream packages depend on it and 
        
             // it's not defined at the root level. 
        
             "topo": {},

because uh... the root turbo.json does have a topo task (see above).

I'm a turborepo noob so perhaps I'm missing something obvious, but I'm filled with confusion while trying to setup Typescript right now 😢.


          Update typescript.mdx

c1b9ea3

fix invalid json

AlexErrant requested review from anthonyshew and a team as code owners

September 4, 2024 21:59

AlexErrant requested a review from tknickman

September 4, 2024 21:59

turbo-orchestrator bot added area: docs needs: triage owned-by: turborepo labels

vercel bot commented Sep 4, 2024

@AlexErrant is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

vercel bot commented Sep 4, 2024

Deployment failed with the following error:

Too many requests - try again in 13 seconds (more than 300, code: "api-deployments-flood-enterprise").

vercel bot commented Sep 4, 2024

Deployment failed with the following error:

Too many requests - try again in 14 seconds (more than 300, code: "api-deployments-flood-enterprise").

vercel bot commented Sep 4, 2024

Deployment failed with the following error:

Too many requests - try again in 15 seconds (more than 300, code: "api-deployments-flood-enterprise").

vercel bot commented Sep 4, 2024

Deployment failed with the following error:

Too many requests - try again in 17 seconds (more than 300, code: "api-deployments-flood-enterprise").

vercel bot commented Sep 4, 2024

Deployment failed with the following error:

Too many requests - try again in 22 seconds (more than 300, code: "api-deployments-flood-enterprise").

anthonyshew approved these changes

View reviewed changes

Contributor

anthonyshew left a comment

Thanks!

topo is explained here: https://turbo.build/repo/docs/crafting-your-repository/configuring-tasks#dependent-tasks-that-can-be-ran-in-parallel

We should add a backlink in a separate PR!

anthonyshew merged commit 8461559 into vercel:main

3 of 12 checks passed

AlexErrant deleted the patch-1 branch

September 4, 2024 22:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: docs needs: triage