fix(watch): await persistent run task instead of abort #9152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
tknickman
approved these changes
Sep 16, 2024
chris-olszewski
commented
Sep 16, 2024
| run_task.abort(); | ||
| // Run should exit shortly after we stop all child tasks, wait for it to finish | ||
| // to ensure all messages are flushed. | ||
| let _ = run_task.await; |
There was a problem hiding this comment.
We don't abort as that seems to still gives us messages in the pipes. I think this is due to the TUI channels being from std::sync::mpsc instead of tokio::sync::mpsc (For now).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the TUI was getting events from a previous run after an
update_taskscall causing it to exit.One can tell this is happening by inspecting the logs:
The TUI is receiving that
web#devfinish event from the previous run which confuses the TUI as web#dev hasn't been started yet in this run. This appears to only happen for tasks that don't exit within a 500ms of receivingSIGINTand need to be forcibly killed.Testing Instructions
Use
create-turboto create a basic repro. Change one of the dev scripts to have a long runningSIGINThandler:Observe that editing root
package.json(just adding/changing"description"will do) whileturbo watch devis running results in a crash:Checkout the changes in this PR and try the same thing. You should observe that
turbo_dev --skip-infer watch devno longer crashes on a rootpackage.jsonchange.You can see that the
SIGINThandler has not run as there is nofindisplayed in the output on the restart.