这是indexloc提供的服务，不要输入任何密码
Skip to content

Document --filter #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Apr 7, 2022
Merged

Document --filter #914

merged 33 commits into from
Apr 7, 2022

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Mar 21, 2022 •
edited
Loading

  • Adds the CLI reference docs for --filter
  • Updates the scoping page to use --filter

@vercel
Copy link

vercel bot commented Mar 21, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/5JpSUtiGpJZYL531NABGw9aEwZqB
✅ Preview: https://turbo-site-git-gsoltis-filterdocs.vercel.sh

@gsoltis gsoltis marked this pull request as ready for review March 22, 2022 18:23
@gsoltis gsoltis changed the base branch from gsoltis/filter to main March 23, 2022 22:00
@gsoltis gsoltis changed the base branch from main to gsoltis/filter March 23, 2022 22:01
@gsoltis gsoltis marked this pull request as draft March 23, 2022 22:01
@gsoltis gsoltis force-pushed the gsoltis/filter_docs branch from 5146c13 to 97034c7 Compare March 23, 2022 22:03
@gsoltis gsoltis changed the base branch from gsoltis/filter to main March 23, 2022 22:03
@gsoltis gsoltis marked this pull request as ready for review March 23, 2022 22:03
@gaspar09
Copy link
Contributor

gaspar09 commented Mar 24, 2022 •
edited
Loading

Are these ready to merge?

@gsoltis
Copy link
Contributor Author

gsoltis commented Mar 24, 2022

@gaspar09 I think we're waiting for 1.2.0 release

@gsoltis
Copy link
Contributor Author

gsoltis commented Apr 5, 2022

Re: deprecation, --scope, --since, --no-deps, and --include-dependencies (but not --ignore) are all technically deprecated.

@jaredpalmer
Copy link
Contributor

jaredpalmer commented Apr 5, 2022 •
edited
Loading

Then we should make a little "Deprecated in 1.2.x" red bubble kind of like we have for <Beta> in Remote Caching and add it to all of the deprecated flags in the reference section

megbird
megbird reviewed Apr 5, 2022
View reviewed changes
Copy link
Contributor

@megbird megbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some non-blocking comments on the overall organization 😄

@jaredpalmer @megbird
Update docs/pages/docs/features/filtering.mdx
3875433 
Co-authored-by: Meg Bird <meg@vercel.com>
@vercel
Copy link

vercel bot commented Apr 6, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Updated Deployment Preview
turbo-site ✅ Deployed Apr 7, 2022 at 8:48PM (UTC) View on Vercel View Preview

@gsoltis gsoltis requested a review from nathanhammond as a code owner April 6, 2022 22:35
@weyert
Copy link
Contributor

weyert commented Apr 7, 2022

How would you rewrite this command to use --filter to avoid the deprecated arguments?
turbo run build --cache-dir=.turbo-cache --include-dependencies --no-deps or
turbo run build --cache-dir=.turbo-cache --include-dependencies

Maybe worth it to add these to the docs or in the blog post? Also posted this question in the blog post PR

@jaredpalmer jaredpalmer merged commit c849316 into main Apr 7, 2022
@jaredpalmer jaredpalmer deleted the gsoltis/filter_docs branch April 7, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@megbird megbird megbird left review comments

@jaredpalmer jaredpalmer jaredpalmer approved these changes

@gaspar09 gaspar09 Awaiting requested review from gaspar09

@nathanhammond nathanhammond Awaiting requested review from nathanhammond

Assignees

@gsoltis gsoltis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gsoltis @gaspar09 @jaredpalmer @weyert @megbird