这是indexloc提供的服务,不要输入任何密码
Skip to content

chore: fix formatting #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

chore: fix formatting #927

wants to merge 2 commits into from

Conversation

samchouse
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Mar 23, 2022

@xenfo is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Mar 24, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/CVC3wavBwtyMBh5wBWQamHXVyyqA
✅ Preview: https://turbo-site-git-fork-xenfo-chore-formatting.vercel.sh

@gsoltis
Copy link
Contributor

gsoltis commented Mar 24, 2022

@xenfo what formatting setup are you using? Some of these match the output from what I'm using (gopls via VSCode), but some do not. We probably ought to standardize so that there isn't churn.

@jaredpalmer
Copy link
Contributor

jaredpalmer commented Mar 24, 2022

@gsoltis can we follow uber's style guide and use their suggest golint in ci? https://github.com/uber-go/guide/blob/master/.golangci.yml and https://github.com/uber-go/guide/blob/master/style.md#linting

@samchouse
Copy link
Contributor Author

@gsoltis I'm using the format bellow.

import (
  // Native imports

  // Turbo imports

  // Third party imports
)

@gsoltis
Copy link
Contributor

gsoltis commented Mar 24, 2022

@xenfo I think @jaredpalmer's suggestion is the best way to tackle this. I'm going to suggest that we close this in favor of an issue to properly set up CI to enforce these things: #934

@samchouse
Copy link
Contributor Author

Does it allow for import sorting?

@gsoltis
Copy link
Contributor

gsoltis commented Mar 24, 2022

It defers to goimports

@samchouse
Copy link
Contributor Author

Alright

@samchouse samchouse closed this Mar 24, 2022
@samchouse samchouse deleted the chore/formatting branch March 24, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants