-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix broken examples causing pnpm test
to fail
#9239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
pnpm test
to fail
tknickman
reviewed
Oct 9, 2024
tknickman
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some phrasing suggestions, but looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On main,
pnpm test
fails (sometimes intermittently, depending on cache scenarios, but all the time without cache). Why? Well..Three of the examples had version 9 lockfiles checked in to git, when version 6 is what's required by their
packageManager
fields. This causes tests to fail quite frequently (example) in many PRs. This happens because when installing in these repos you getLockfile not compatible with current pnpm
errors, and it totally blows away the old lockfile and grabs a new one. Then, since our Next.js version is specified as^4.1.1
in these package.jsons, it will resolve to4.2.15
instead of the old4.1.1
. Then, it turns out that this minor update causes this diff in thenext-env.d.ts
file:The fact of that diff happening causes turbo to not be "FULL TURBO", which the example tests checks for. That then causes the test suite to fail because there's a turbo cache miss.
Testing Instructions
pnpm test
should now pass.