feat: warn on empty cache #9236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
tknickman
approved these changes
Oct 8, 2024
057240f to
ccd3840
Compare
chris-olszewski
added a commit
that referenced
this pull request
Oct 17, 2024
### Description I've noticed this integration test has been flakey lately: - https://github.com/vercel/turborepo/actions/runs/11387765428/job/31683165527 - https://github.com/vercel/turborepo/actions/runs/11386983833/job/31680539914 - https://github.com/vercel/turborepo/actions/runs/11356438462/job/31587646091 Partially reverts changes from #9236 for the cases that I've seen fail. I don't remember this test being flakey before, so I'm changing it back. I'm assuming we're now capturing [some lines](https://github.com/vercel/turborepo/blob/ef2dc90030c6103393d42bdd5fb7f3584f1466a8/turborepo-tests/integration/tests/run-logging/log-order-stream.t#L47) that aren't deterministic in ordering. ### Testing Instructions Ran the test a few times and didn't get any failures. Hopefully CI is green.
1 task
NicholasLYang
added a commit
that referenced
this pull request
Oct 21, 2024
### Description In #9236 I added a check if the task output globs are empty. Turns out we need to check if the output globs only has a single entry for the log file. Fixes #9291 ### Testing Instructions `basic_monorepo` has both a task that has globs and no outputs and a task that has empty globs and no outputs. Note that we warn for one and not the other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Warns if cache payload consists of just the log file and output globs are specified.
Testing Instructions
Turns out all of our test fixtures have empty outputs so we get a lot of these warnings in tests