这是indexloc提供的服务，不要输入任何密码
Skip to content

chore(ci): enable corepack for npm in integration tests #9233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 18, 2024
Merged

chore(ci): enable corepack for npm in integration tests #9233

merged 3 commits into from
Oct 18, 2024

Conversation

@mehulkar
Copy link
Contributor

@mehulkar mehulkar commented Oct 8, 2024

No description provided.

@vercel
Copy link
Contributor

vercel bot commented Oct 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 1:36pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 1:36pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 1:36pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 1:36pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 1:36pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 1:36pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 1:36pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 1:36pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 1:36pm

@styfle styfle changed the title chore(ci): enable coreppack for npm in integration tests chore(ci): enable corepack for npm in integration tests Oct 8, 2024
styfle
styfle reviewed Oct 8, 2024
View reviewed changes
styfle
styfle reviewed Oct 8, 2024
View reviewed changes
Copy link
Member

@styfle styfle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a typo.

Alternatively you could do without checking the value of $pkgManager

corepack enable $pkgManager

@mehulkar mehulkar marked this pull request as ready for review October 8, 2024 17:53
@mehulkar mehulkar requested a review from a team as a code owner October 8, 2024 17:53
@mehulkar mehulkar merged commit 6ac0456 into main Oct 18, 2024
38 checks passed
@mehulkar mehulkar deleted the mk/corepack-npm-tests branch October 18, 2024 13:53
@anthonyshew anthonyshew mentioned this pull request Oct 22, 2024
Merged
@renovate renovate bot mentioned this pull request Oct 25, 2024
Merged
1 task
@Lavish1999 Lavish1999 mentioned this pull request Nov 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@styfle styfle styfle approved these changes

@dimitropoulos dimitropoulos Awaiting requested review from dimitropoulos dimitropoulos is a code owner automatically assigned from vercel/turbo-oss

+1 more reviewer

@NicholasLYang NicholasLYang NicholasLYang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mehulkar @styfle @NicholasLYang