这是indexloc提供的服务，不要输入任何密码
Skip to content

docs: add missing } and remove comma #9223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 7, 2024
Merged

docs: add missing } and remove comma #9223

merged 3 commits into from
Oct 7, 2024

Conversation

morinokami
Copy link
Contributor

@morinokami morinokami commented Oct 5, 2024 •
edited
Loading

Description

  • The JSON code block's indentation has been corrected for better readability and proper JSON structure
  • Added the inputs property to build to match the actual turbo.json content
  • Added a missing } to the JSON code block and removed a trailing comma

Testing Instructions

@morinokami morinokami requested review from anthonyshew and a team as code owners October 5, 2024 13:11
@turbo-orchestrator turbo-orchestrator bot added area: docs Improvements or additions to documentation needs: triage New issues get this label. Remove it after triage owned-by: turborepo labels Oct 5, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2024 3:22am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2024 3:22am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2024 3:22am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2024 3:22am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2024 3:22am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Oct 6, 2024 3:22am

@vercel Vercel
Copy link

vercel bot commented Oct 5, 2024

@morinokami is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@ijjk
Copy link
Member

ijjk commented Oct 5, 2024

Allow CI Workflow Run

  • approve CI run for commit: 0d9c2e4

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Oct 5, 2024 •
edited
Loading

Allow CI Workflow Run

  • approve CI run for commit: 2029f4c

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@anthonyshew
Copy link
Contributor

Hi, thanks for the contribution!

It looks like we're missing the last } and the trailing comma does need to be removed, but we're happy with the indentation and configuration shown.

Can you update only for the } and comma? Thanks!

@morinokami
Copy link
Contributor Author

@anthonyshew Thanks for your feedback! I'll update the code accordingly.

@morinokami
Copy link
Contributor Author

@anthonyshew Hmm, I added the missing } and removed the comma without formatting, but it seems that lint-staged adds indentation on git commit. What should I do?

@anthonyshew
Copy link
Contributor

Hm, that sounds like a problem on our end. If you could git commit -m "your message" --no-verify to work around lint-staged for now, I'll look into that later.

@morinokami morinokami changed the title docs: fix indentation and add missing item docs: add missing } and remove comma Oct 6, 2024
@morinokami
Copy link
Contributor Author

@anthonyshew Thank you for the advice. I have committed using --no-verify.

anthonyshew
anthonyshew approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you!

@anthonyshew anthonyshew merged commit d9a84b0 into vercel:main Oct 7, 2024
29 of 39 checks passed
@anthonyshew anthonyshew mentioned this pull request Oct 7, 2024
Merged
@anthonyshew anthonyshew mentioned this pull request Oct 22, 2024
Merged
@renovate renovate bot mentioned this pull request Nov 1, 2024
Merged
1 task
@Lavish1999 Lavish1999 mentioned this pull request Nov 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonyshew anthonyshew anthonyshew approved these changes

@NicholasLYang NicholasLYang Awaiting requested review from NicholasLYang NicholasLYang is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
area: docs Improvements or additions to documentation needs: triage New issues get this label. Remove it after triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@morinokami @ijjk @anthonyshew