这是indexloc提供的服务，不要输入任何密码
Skip to content

Log changed package names instead of full struct #8971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2024
+7 −2
Merged

Log changed package names instead of full struct #8971

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions crates/turborepo-lib/src/run/scope/change_detector.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,14 @@ impl<'a> GitChangeDetector for ScopeChangeDetector<'a> {
}
PackageChanges::Some(packages) => {
debug!(
"determined {} packages changed: {packages:?}",
packages.len()
"{} packages changed: {:?}",
packages.len(),
&packages
.iter()
.map(|x| x.name.to_string())
.collect::<Vec<String>>()
Comment on lines +143 to +146
Copy link
Contributor Author

@mehulkar mehulkar Aug 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sort also? or is packages already sorted?

Copy link
Contributor

@chris-olszewski chris-olszewski Aug 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, sorting is good here. Packages are stored in a hash set so just iterating over them won't yield a stable order.

);

Ok(packages
.iter()
.map(|package| package.name.to_owned())
Expand Down