Replace rimraf to native #8729
Merged
Replace rimraf to native #8729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
@torresgol10 is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Contributor
|
Looks like some failures in the JS package tests: https://github.com/vercel/turbo/actions/runs/9901744124/job/27354620086?pr=8729 |
Contributor
Author
|
@anthonyshew I forgot to pass you the parameters for the recursion deletion, sorry. |
anthonyshew
approved these changes
Jul 23, 2024
Contributor
anthonyshew
left a comment
There was a problem hiding this comment.
No worries! Looks good to go now. Thank you once again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We remove the dependency on
rimrafand replace it with native, keeping the functionality inpackages/create-turboandpackages/turbo-test-utils