-
Notifications
You must be signed in to change notification settings - Fork 2k
Prep before SSO login flow work #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/32ZWMkVUHofRkGn7N1pK4K3oYJo6 |
@xenfo this PR includes an example of what I mean by gradually adopting |
@gsoltis should I continue how I am doing it right now and figure out how to appropriately commit to |
@xenfo As a reviewer, I would find it much easier to go one command per PR. Then we could do a final PR to wire them all up to a root command. FWIW, I'm excited to see this happening and think it's a good step. There's no reason |
}) | ||
}, | ||
} | ||
loginCommand.SetArgs(args) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:smart_meme:
cobra
for thelogin
command. This can serve as a model for an eventual migration tocobra
for everythingturbo login
should now respectCtrl+C
login.go
run
function to make it a bit more testablecli.ColoredUi
utilOpenBrowser
now returns an error rather than fatally exiting.