fix(yarn-pnp): fixing generateBinPath when yarn pnp is enabled #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/ELh1KRp4MSgPuyBA1YyAc3NXnnjY |
The call to require.resolve(turbo) was failing because the package does not have a main export defined in the package.json, nor is there an index.js. Since we are just looking for the directory the package is unplugged into, we can resolve the path to the package.json and get the dirname of that.
cdf14cb to
d5fe5d4
Compare
gsoltis
approved these changes
Mar 1, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Mar 8, 2022
Regarding #693 (comment) I believe this at least partially addresses Issue: #693, but the scope of the issue is unclear. More specifically this removes the general check for yarn pnp and moves it into the prune command instead as this is the part that likely has remaining issues with pnp since nothing else that I'm aware of needs to know about `node_modules`. This PR builds off of #795, as otherwise you can't even run turbo to be able to hit the previous nodeLinker checks. Let me know if you would like me to change things around so that it is more explicitly enabling for the run task as opposed to enabling for all but prune.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned here: #693 (comment)
The call to require.resolve(turbo) was failing because the package does not have a main export
defined in the package.json, nor is there an index.js. Since we are just looking for the directory
the package is unplugged into, we can resolve the path to the package.json and get the dirname
of that.
This basically fixes things to the point where the binary is able to execute before hitting the nodeLinker
checks and bailing out with a proper error message.
Before:
After: