fix: upstream eslint-plugin-react issue causing next build and lint to fail #779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/JBMC7jkrpBpt98m5Dp9cYq1VyW53 |
|
I'm not a maintainer or contributor to this project, but this doesn't seem wise as you would lose the react/jsx-key linting when you're using arrays. |
|
Correct not planning to keep this around for very long other than to cut a canary and get our CI tests working again. The Next.js is already working on a patch as we speak. |
kodiakhq bot
pushed a commit
that referenced
this pull request
Feb 21, 2023
It was added in #779 as a temporary fix but forgotten about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes upsteam jsx-eslint/eslint-plugin-react#3215