这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(cli): Fix install on node 16 on ubuntu #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2022
Merged

fix(cli): Fix install on node 16 on ubuntu #778

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0895db
Fix install on node 16 on ubuntu
jaredpalmer Feb 25, 2022
4317790
Merge branch 'main' into fix/node-16-ubuntu-install
jaredpalmer Feb 25, 2022
456753d
Merge branch 'main' into fix/node-16-ubuntu-install
jaredpalmer Feb 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion cli/npm/turbo-install/install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,20 @@ let isToPathJS = true;
function validateBinaryVersion(...command) {
command.push("--version");
const stdout = child_process
.execFileSync(command.shift(), command)
.execFileSync(command.shift(), command, {
// Without this, this install script strangely crashes with the error
// "EACCES: permission denied, write" but only on Ubuntu Linux when node is
// installed from the Snap Store. This is not a problem when you download
// the official version of node. The problem appears to be that stderr
// (i.e. file descriptor 2) isn't writable?
//
// More info:
// - https://snapcraft.io/ (what the Snap Store is)
// - https://nodejs.org/dist/ (download the official version of node)
// - https://github.com/evanw/esbuild/issues/1711#issuecomment-1027554035
//
stdio: "pipe",
})
.toString()
.trim();
if (stdout !== TURBO_VERSION) {
Expand Down