这是indexloc提供的服务，不要输入任何密码
Skip to content

Start splitting the Run command up #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 17, 2022
Merged

Start splitting the Run command up #752

merged 7 commits into from
Feb 17, 2022

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Feb 16, 2022

This PR makes a few changes to Run. The intention is to separate out a few distinct pieces:

  • The complete graph, inferred from the the filesystem and pipeline configuration. This should be reusable across multiple runs on the same filesystem / pipeline
  • Run specific configuration: what tasks to run, whether to include dependencies, etc.
  • The mechanics of how to execute the run. In parallel? Cache the output? etc.

Review note: it may be easier to go commit by commit.

@vercel
Copy link

vercel bot commented Feb 16, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/CmWToLBJYCJSePNbPAvVbr1gd4eG
✅ Preview: https://turbo-site-git-gsoltis-runsplit.vercel.sh

jaredpalmer
jaredpalmer previously approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@jaredpalmer jaredpalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Bit by bit we'll keep moving things up

@kodiakhq kodiakhq bot merged commit 09223bf into main Feb 17, 2022
@kodiakhq kodiakhq bot deleted the gsoltis/run_split branch February 17, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpalmer jaredpalmer jaredpalmer approved these changes

@gaspar09 gaspar09 Awaiting requested review from gaspar09

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsoltis @jaredpalmer