-
Notifications
You must be signed in to change notification settings - Fork 2k
Large Monorepo Benchmark #740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
name: Large Repo Benchmark | ||
|
||
on: | ||
push: | ||
branches: ["main"] | ||
pull_request: | ||
types: [opened, synchronize] | ||
|
||
jobs: | ||
build: | ||
name: Run Benchmarks | ||
timeout-minutes: 40 | ||
runs-on: ${{ matrix.os }} | ||
strategy: | ||
matrix: | ||
os: [ubuntu-latest, macos-latest] | ||
|
||
steps: | ||
- name: Check out code | ||
uses: actions/checkout@v2 | ||
with: | ||
fetch-depth: 2 | ||
|
||
- name: Set up Go 1.x | ||
uses: actions/setup-go@v2 | ||
with: | ||
go-version: 1.17.6 | ||
id: go | ||
|
||
- name: Build | ||
run: cd cli && make turbo | ||
|
||
- name: Setup Node.js environment | ||
uses: actions/setup-node@v2 | ||
|
||
- name: Install dependencies | ||
run: cd benchmark && yarn | ||
|
||
- name: Run benchmarks | ||
run: cd benchmark && yarn benchmark | ||
|
||
- name: Store Benchmark Result | ||
uses: benchmark-action/github-action-benchmark@v1 | ||
with: | ||
name: "${{ runner.os }} Benchmark" | ||
# What benchmark tool the output is formatted as | ||
tool: "customSmallerIsBetter" | ||
output-file-path: ./benchmark/benchmarks.json | ||
benchmark-data-dir-path: benchmarks/large-repo/${{ runner.os }} | ||
auto-push: ${{ github.event_name == 'push' }} | ||
comment-on-alert: true | ||
comment-always: true | ||
# GitHub API token to make a commit on push, and a comment always | ||
github-token: ${{ secrets.GITHUB_TOKEN }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
large-monorepo | ||
benchmarks.json |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
"name": "benchmark", | ||
"version": "1.0.0", | ||
"dependencies": { | ||
"esbuild": "^0.14.21", | ||
"esbuild-register": "^3.3.2", | ||
"fs-extra": "^10.0.0" | ||
}, | ||
"scripts": { | ||
"benchmark": "node -r esbuild-register src/index.ts" | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,224 @@ | ||
import cp from "child_process"; | ||
import fs from "fs"; | ||
import fse from "fs-extra"; | ||
import path from "path"; | ||
|
||
const REPO_ROOT = "large-monorepo"; | ||
const REPO_ORIGIN = "https://github.com/gsoltis/large-monorepo.git"; | ||
const REPO_PATH = path.join(process.cwd(), REPO_ROOT); | ||
const REPETITIONS = 5; | ||
|
||
const DEFAULT_EXEC_OPTS = { stdio: "ignore" as const, cwd: REPO_PATH }; | ||
const TURBO_BIN = path.resolve(path.join("..", "cli", "turbo")); | ||
const DEFAULT_CACHE_PATH = path.join( | ||
REPO_PATH, | ||
"node_modules", | ||
".cache", | ||
"turbo" | ||
); | ||
const ALT_CACHE_PATH = path.join( | ||
REPO_PATH, | ||
"node_modules", | ||
".cache", | ||
"turbo-benchmark" | ||
); | ||
|
||
type Benchmark = { | ||
name: string; | ||
unit: string; | ||
value: number; | ||
range?: string; | ||
extra?: string; | ||
}; | ||
|
||
function setup(): void { | ||
// Clone repo if it doesn't exist, run clean | ||
if (fs.existsSync(REPO_ROOT)) { | ||
// reset the repo, remove all changed or untracked files | ||
cp.execSync( | ||
`cd ${REPO_ROOT} && git reset --hard HEAD && git clean -f -d -X`, | ||
{ | ||
stdio: "inherit", | ||
} | ||
); | ||
} else { | ||
cp.execSync(`git clone ${REPO_ORIGIN}`, { stdio: "ignore" }); | ||
} | ||
|
||
// Run install so we aren't benchmarking node_modules ... | ||
|
||
cp.execSync("yarn install", DEFAULT_EXEC_OPTS); | ||
} | ||
|
||
function cleanTurboCache(): void { | ||
if (fs.existsSync(DEFAULT_CACHE_PATH)) { | ||
console.log("clearing cache"); | ||
fs.rmSync(DEFAULT_CACHE_PATH, { recursive: true }); | ||
} | ||
} | ||
|
||
function cleanBuild(): Benchmark { | ||
const timings: number[] = []; | ||
let total = 0; | ||
const isLocal = process.argv[process.argv.length - 1] == "--local"; | ||
// We aren't really benchmarking this one, it OOMs if run in full parallel | ||
// on GH actions | ||
const repetitions = isLocal ? REPETITIONS : 1; | ||
const concurrency = isLocal ? "" : " --concurrency=1"; | ||
for (let i = 0; i < repetitions; i++) { | ||
// clean first, we'll leave the cache in place for subsequent builds | ||
cleanTurboCache(); | ||
const start = new Date().getTime(); | ||
cp.execSync(`${TURBO_BIN} run build${concurrency}`, DEFAULT_EXEC_OPTS); | ||
const end = new Date().getTime(); | ||
const timing = end - start; | ||
total += timing; | ||
timings.push(timing); | ||
} | ||
const avg = total / REPETITIONS; | ||
const max = Math.max(...timings); | ||
const min = Math.min(...timings); | ||
return { | ||
name: "Clean Build", | ||
value: avg, | ||
unit: "ms", | ||
range: String(max - min), | ||
}; | ||
} | ||
|
||
function cachedBuild(): Benchmark { | ||
const timings: number[] = []; | ||
let total = 0; | ||
for (let i = 0; i < REPETITIONS; i++) { | ||
const start = new Date().getTime(); | ||
cp.execSync(`${TURBO_BIN} run build`, DEFAULT_EXEC_OPTS); | ||
const end = new Date().getTime(); | ||
const timing = end - start; | ||
total += timing; | ||
timings.push(timing); | ||
} | ||
const avg = total / REPETITIONS; | ||
const max = Math.max(...timings); | ||
const min = Math.min(...timings); | ||
return { | ||
name: "Cached Build - no changes", | ||
value: avg, | ||
unit: "ms", | ||
range: String(max - min), | ||
}; | ||
} | ||
|
||
function saveCache() { | ||
// Remove any existing backup | ||
if (fs.existsSync(ALT_CACHE_PATH)) { | ||
fs.rmSync(ALT_CACHE_PATH, { recursive: true }); | ||
} | ||
// copy the current cache to the backup | ||
if (fs.existsSync(DEFAULT_CACHE_PATH)) { | ||
fse.copySync(DEFAULT_CACHE_PATH, ALT_CACHE_PATH, { recursive: true }); | ||
} else { | ||
// make an empty cache | ||
fs.mkdirSync(ALT_CACHE_PATH, { recursive: true }); | ||
} | ||
} | ||
|
||
function restoreSavedCache() { | ||
// Remove any existing cache | ||
if (fs.existsSync(DEFAULT_CACHE_PATH)) { | ||
fs.rmSync(DEFAULT_CACHE_PATH, { recursive: true }); | ||
} | ||
// Copy the backed-up cache to the real cache | ||
fse.copySync(ALT_CACHE_PATH, DEFAULT_CACHE_PATH, { recursive: true }); | ||
} | ||
|
||
function cachedBuildWithDelta(): Benchmark { | ||
// Save existing cache just once, we'll restore from it each time | ||
saveCache(); | ||
|
||
// Edit a file in place | ||
const file = path.join( | ||
REPO_PATH, | ||
"packages", | ||
"crew", | ||
"important-feature-0", | ||
"src", | ||
"lib", | ||
"important-component-0", | ||
"important-component-0.tsx" | ||
); | ||
const contents = fs.readFileSync(file).toString("utf-8"); | ||
// make a small edit | ||
const updated = contents.replace("-0!", "-0!!"); | ||
fs.writeFileSync(file, updated); | ||
|
||
const timings: number[] = []; | ||
let total = 0; | ||
for (let i = 0; i < REPETITIONS; i++) { | ||
// Make sure we're starting with the cache from before we make the source code edit | ||
restoreSavedCache(); | ||
const start = new Date().getTime(); | ||
cp.execSync(`${TURBO_BIN} run build`, DEFAULT_EXEC_OPTS); | ||
const end = new Date().getTime(); | ||
const timing = end - start; | ||
total += timing; | ||
timings.push(timing); | ||
} | ||
const avg = total / REPETITIONS; | ||
const max = Math.max(...timings); | ||
const min = Math.min(...timings); | ||
return { | ||
name: "Cached Build - source code change", | ||
value: avg, | ||
unit: "ms", | ||
range: String(max - min), | ||
}; | ||
} | ||
|
||
function cachedBuildWithDependencyChange(): Benchmark { | ||
// Save existing cache just once, we'll restore from it each time | ||
saveCache(); | ||
|
||
// Edit a dependency | ||
const file = path.join(REPO_PATH, "apps", "navigation", "package.json"); | ||
const contents = JSON.parse(fs.readFileSync(file).toString("utf-8")); | ||
contents.dependencies["crew-important-feature-0"] = "*"; | ||
fs.writeFileSync(file, JSON.stringify(contents, null, 2)); | ||
|
||
const timings: number[] = []; | ||
let total = 0; | ||
for (let i = 0; i < REPETITIONS; i++) { | ||
// Make sure we're starting with the cache from before we made the dependency edit | ||
restoreSavedCache(); | ||
const start = new Date().getTime(); | ||
cp.execSync(`${TURBO_BIN} run build`, DEFAULT_EXEC_OPTS); | ||
const end = new Date().getTime(); | ||
const timing = end - start; | ||
total += timing; | ||
timings.push(timing); | ||
} | ||
const avg = total / REPETITIONS; | ||
const max = Math.max(...timings); | ||
const min = Math.min(...timings); | ||
return { | ||
name: "Cached Build - dependency change", | ||
value: avg, | ||
unit: "ms", | ||
range: String(max - min), | ||
}; | ||
} | ||
|
||
cp.execSync(`${TURBO_BIN} --version`, { stdio: "inherit" }); | ||
|
||
const benchmarks: Benchmark[] = []; | ||
console.log("setup"); | ||
setup(); | ||
console.log("clean build"); | ||
benchmarks.push(cleanBuild()); | ||
console.log("cached build - no change"); | ||
benchmarks.push(cachedBuild()); | ||
console.log("cached build - code change"); | ||
benchmarks.push(cachedBuildWithDelta()); | ||
console.log("cached build - dependency change"); | ||
benchmarks.push(cachedBuildWithDependencyChange()); | ||
console.log(JSON.stringify(benchmarks, null, 2)); | ||
fs.writeFileSync("benchmarks.json", JSON.stringify(benchmarks, null, 2)); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
Edit
->Add
sincecrew-important-feature-0
is not originally a dependency ofapps/navigation/package.json