feat: add support for JSON with comments turbo.json file
#745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the `turbo.json` file to contain comments
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/H56SiWis6jGxkJGhNiT5UsuzibZ1 |
|
@gsoltis I am not sure why the benchmark build step is failing |
jaredpalmer
suggested changes
Feb 16, 2022
gsoltis
approved these changes
Feb 16, 2022
|
Any more changes needed to get it merged? @jaredpalmer @gsoltis |
jaredpalmer
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the
turbo.jsonfile to contain commentsMakes it easier to explain the pipeline when they are quite large :)
So that future @weyert and his colleagues know what's going on!
Fixes #644