add custom_extensions to resolve options context #7367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
🟢 Turbopack Benchmark CI successful 🟢Thanks |
Contributor
|
✅ This change can build |
Contributor
|
wbinnssmith
reviewed
Feb 13, 2024
wbinnssmith
approved these changes
Feb 13, 2024
| module.exports = { | ||
| experimental: { | ||
| turbo: { | ||
| resolveExtensions: [ |
Contributor
There was a problem hiding this comment.
I think it would be a good idea to move functionality like this to a shared field that both webpack and turbopack read from
Contributor
There was a problem hiding this comment.
Either way, this needs to be added to the typescript types
Contributor
There was a problem hiding this comment.
oh right, this isn't the next.js repo yet, we should really move the docs over
Contributor
There was a problem hiding this comment.
The original comment still stands though, maybe this should be something like experimental.compiler.resolveExtensions?
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Will Binns-Smith <wbinnssmith@gmail.com>
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Feb 15, 2024
…#62092) ### What? see vercel/turborepo#7398 ### Turbopack Changes * vercel/turborepo#7367 <!-- Tobias Koppers - add custom_extensions to resolve options context --> * vercel/turborepo#7398 <!-- Tobias Koppers - add support for dynamic requests in require() and import() --> Closes PACK-2513
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description enables to customize extensions in next.js ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2482 --------- Co-authored-by: Will Binns-Smith <wbinnssmith@gmail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description enables to customize extensions in next.js ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2482 --------- Co-authored-by: Will Binns-Smith <wbinnssmith@gmail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description enables to customize extensions in next.js ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2482 --------- Co-authored-by: Will Binns-Smith <wbinnssmith@gmail.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description enables to customize extensions in next.js ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2482 --------- Co-authored-by: Will Binns-Smith <wbinnssmith@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
enables to customize extensions in next.js
Testing Instructions
Closes PACK-2482