这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix existing benchmarks #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 11, 2022
Merged

Fix existing benchmarks #718

merged 3 commits into from
Feb 11, 2022

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Feb 10, 2022

  • bench/turbo benchmark depends on building turbo so that it works from a clean state
  • generate.mjs script now reads from workspace.json for nx, since that's the file that gets written
  • Removed bench/turbo-new, it doesn't appear used or to work without something generating the turbo-new binary

@vercel
Copy link

vercel bot commented Feb 10, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/6SRAkEGWkgr2B2HXnXvRA3nhEHUK
✅ Preview: https://turbo-site-git-gsoltis-fixexistingbench.vercel.sh

@gsoltis gsoltis added the pr: automerge Kodiak will merge these automatically after checks pass label Feb 10, 2022
@jaredpalmer
Copy link
Contributor

jaredpalmer commented Feb 10, 2022 •
edited
Loading

idea w/turbo-new was for times when you want to compare current commit or main or something vs. the change you're working on locally, i'd keep around or replace w/something with the functionality

@gsoltis
Copy link
Contributor Author

gsoltis commented Feb 10, 2022

Ok, I put turbo-new back. I don't have a specific replacement in mind right now.

@jaredpalmer jaredpalmer merged commit e459bff into main Feb 11, 2022
@kodiakhq kodiakhq bot deleted the gsoltis/fix_existing_bench branch February 11, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpalmer jaredpalmer Awaiting requested review from jaredpalmer

@gaspar09 gaspar09 Awaiting requested review from gaspar09

Assignees
No one assigned
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsoltis @jaredpalmer