Minify generated schema.json #726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/6zWrB2fDFmyiXjWqsD1wJ6EKrW4u |
|
We should really treat the schema file as generated output. So actually, can you do the following?
Now we can minify and also just have single file diffs |
|
Just adding the |
jaredpalmer
approved these changes
Feb 16, 2022
Schniz
added a commit
that referenced
this pull request
Mar 3, 2022
This commit continues the amazing work done in #634 and #726. Instead of generating the JSON schema from a separate TypeScript file, this commit introduces a new CLI (to avoid bloating the main one) that will output a JSON schema from the struct definition itself, including the actual code comments. This will allow to better integration and to avoid differences between the two codebases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added
--minifyoption tots-json-schema-generatorbecause some of my schemas have gotten bigger.I've just enabled it here too :)