这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(run): no-cache flag #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 19, 2022
Merged

fix(run): no-cache flag #699

merged 11 commits into from
Feb 19, 2022

Conversation

samchouse
Copy link
Contributor

Fixed the —no-cache flag.

@vercel
Copy link

vercel bot commented Feb 8, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/7PrskCZ2XUSxz7yjNXDEmz79PdzM
✅ Preview: https://turbo-site-git-fork-xenfo-fix-no-cache.vercel.sh

jaredpalmer
jaredpalmer suggested changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@jaredpalmer jaredpalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add e2e test for this?

@samchouse
Copy link
Contributor Author

I guess I'm a bit mixed up about what --no-cache does thought it was like --force. Can you lmk so I can add E2E.

@jaredpalmer
Copy link
Contributor

  • --force ignores a cache hit and always executes
  • --no-cache avoids saving to cache (calling .Put)

@jaredpalmer
Copy link
Contributor

Needs e2e tests, but looks fine

@samchouse
Copy link
Contributor Author

@jaredpalmer added E2E tests

jaredpalmer
jaredpalmer suggested changes Feb 19, 2022
View reviewed changes
@kodiakhq kodiakhq bot merged commit cce1ca7 into vercel:main Feb 19, 2022
@samchouse samchouse deleted the fix/no-cache branch February 19, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpalmer jaredpalmer jaredpalmer approved these changes

@gaspar09 gaspar09 Awaiting requested review from gaspar09

@gsoltis gsoltis Awaiting requested review from gsoltis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samchouse @jaredpalmer