这是indexloc提供的服务,不要输入任何密码
Skip to content

Track child exit codes and propagate them #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Conversation

gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Feb 8, 2022

Track if we saw any child exit with a non-zero exit code, and use the highest one.

Fixes #694

@vercel
Copy link

vercel bot commented Feb 8, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/AHQ68FRTAM4RMmwZanTABixwufQy
✅ Preview: https://turbo-site-git-gsoltis-fixexitcodes.vercel.sh

@gsoltis gsoltis force-pushed the gsoltis/fix_exit_codes branch from e7c917f to 3aef620 Compare February 8, 2022 16:48
@gsoltis gsoltis marked this pull request as ready for review February 8, 2022 16:48
@gsoltis gsoltis added the pr: automerge Kodiak will merge these automatically after checks pass label Feb 8, 2022
@kodiakhq kodiakhq bot merged commit c30e5f5 into main Feb 8, 2022
@gsoltis gsoltis deleted the gsoltis/fix_exit_codes branch February 8, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: automerge Kodiak will merge these automatically after checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.1.3 Canary regression: Exit code 0 is always returned
2 participants