这是indexloc提供的服务，不要输入任何密码
Skip to content

fix(turborepo): Corepack may have concurrency problems #5538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(turborepo): Corepack may have concurrency problems #5538

wants to merge 1 commit into from

Conversation

@gsoltis
Copy link
Contributor

@gsoltis gsoltis commented Jul 15, 2023

Description

  • set examples to run with concurrency=1 so as not to hit corepack concurrency issues. If this proves to fix the problem, we can investigate more efficient fixes

Testing Instructions

The examples workflow

@vercel
Copy link
Contributor

vercel bot commented Jul 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2023 8:20pm
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Jul 15, 2023 8:20pm
examples-cra-web ⬜️ Ignored (Inspect) Jul 15, 2023 8:20pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Jul 15, 2023 8:20pm
examples-gatsby-web ⬜️ Ignored (Inspect) Jul 15, 2023 8:20pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Jul 15, 2023 8:20pm
examples-native-web ⬜️ Ignored (Inspect) Jul 15, 2023 8:20pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Jul 15, 2023 8:20pm
examples-svelte-web ⬜️ Ignored (Inspect) Jul 15, 2023 8:20pm
examples-tailwind-web ⬜️ Ignored (Inspect) Jul 15, 2023 8:20pm
examples-vite-web ⬜️ Ignored (Inspect) Jul 15, 2023 8:20pm

@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2023

✅ This change can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2023

Linux Benchmark for adc8a8d

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 5547.77µs ± 62.63µs 5488.67µs ± 24.52µs -1.07%
bench_hmr_to_eval/Turbopack CSR/1000 modules 5110.33µs ± 27.41µs 5164.18µs ± 74.17µs +1.05%
bench_startup/Turbopack CSR/1000 modules 807.26ms ± 1.13ms 808.27ms ± 2.77ms +0.13%

@gsoltis
Copy link
Contributor Author

gsoltis commented Jul 15, 2023

Alternate approach: #5539

@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2023 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2023

MacOS Benchmark for adc8a8d

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 27.25ms ± 0.15ms 26.39ms ± 0.13ms -3.15% -1.11%
bench_startup/Turbopack CSR/1000 modules 3125.39ms ± 34.72ms 3387.99ms ± 78.11ms +8.40% +1.16%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 27.25ms ± 0.15ms 26.39ms ± 0.13ms -3.15% -1.11%
bench_hmr_to_eval/Turbopack CSR/1000 modules 25.67ms ± 0.46ms 23.15ms ± 1.06ms -9.80%
bench_startup/Turbopack CSR/1000 modules 3125.39ms ± 34.72ms 3387.99ms ± 78.11ms +8.40% +1.16%

@gsoltis
Copy link
Contributor Author

gsoltis commented Jul 16, 2023

Closing in favor of #5539

@gsoltis gsoltis closed this Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area: ci

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gsoltis