Implement hashing fallback #5505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
Contributor
🟢 CI successful 🟢Thanks |
chris-olszewski
approved these changes
Jul 13, 2023
| "failed to use git to hash files: {}. Falling back to manual", | ||
| e | ||
| ); | ||
| crate::manual::get_package_file_hashes_from_processing_gitignore( |
Contributor
There was a problem hiding this comment.
I carefully moved a lot of this fallback into "application" code inside of Go because doing the fallback lower-level caused the "we have three different ways that we hash files which are only mostly-compatible" situation.
I'd much prefer to hoist this back into application code out of scm.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing Instructions
Added a new test that verifies we can still hash when git errors