这是indexloc提供的服务，不要输入任何密码
Skip to content

feat(turbopack_core): define trait for diagnostics #5503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2023
Merged

feat(turbopack_core): define trait for diagnostics #5503

merged 1 commit into from
Jul 20, 2023

Conversation

@kwonoj
Copy link
Contributor

@kwonoj kwonoj commented Jul 12, 2023

Description

Extracting trait definition from vercel/next.js#52356, renamed it for more generic usage that turbopack can emit any kind of arbitary metadata, but next-swc can use it as telemetry for its subset.

@kwonoj kwonoj requested a review from a team as a code owner July 12, 2023 16:53
@vercel
Copy link
Contributor

vercel bot commented Jul 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2023 5:46pm
10 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jul 20, 2023 5:46pm
examples-cra-web ⬜️ Ignored (Inspect) Visit Preview Jul 20, 2023 5:46pm
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jul 20, 2023 5:46pm
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jul 20, 2023 5:46pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jul 20, 2023 5:46pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jul 20, 2023 5:46pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Visit Preview Jul 20, 2023 5:46pm
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jul 20, 2023 5:46pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jul 20, 2023 5:46pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jul 20, 2023 5:46pm

@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2023 •
edited
Loading

✅ This change can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2023 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2023

Linux Benchmark for 41d5034

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 5401.17µs ± 24.10µs 5369.72µs ± 15.76µs -0.58%
bench_hmr_to_eval/Turbopack CSR/1000 modules 5010.49µs ± 26.02µs 5152.49µs ± 106.47µs +2.83%
bench_startup/Turbopack CSR/1000 modules 805.97ms ± 1.12ms 810.98ms ± 4.70ms +0.62%

@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2023

MacOS Benchmark for 41d5034

Test Base PR % Significant %
bench_hmr_to_eval/Turbopack CSR/1000 modules 24.05ms ± 0.69ms 26.77ms ± 0.22ms +11.30% +3.53%
bench_startup/Turbopack CSR/1000 modules 8684.90ms ± 776.61ms 3656.05ms ± 81.14ms -57.90% -46.46%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 27.32ms ± 0.07ms 27.33ms ± 0.14ms +0.02%
bench_hmr_to_eval/Turbopack CSR/1000 modules 24.05ms ± 0.69ms 26.77ms ± 0.22ms +11.30% +3.53%
bench_startup/Turbopack CSR/1000 modules 8684.90ms ± 776.61ms 3656.05ms ± 81.14ms -57.90% -46.46%

@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023

Linux Benchmark for 3bd8e5d

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 5362.64µs ± 35.16µs 5336.97µs ± 34.26µs -0.48%
bench_hmr_to_eval/Turbopack CSR/1000 modules 4993.46µs ± 21.27µs 5374.44µs ± 419.15µs +7.63%
bench_startup/Turbopack CSR/1000 modules 793.80ms ± 2.34ms 799.81ms ± 5.10ms +0.76%

@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023

MacOS Benchmark for 3bd8e5d

Test Base PR % Significant %
bench_startup/Turbopack CSR/1000 modules 5583.76ms ± 795.46ms 3205.98ms ± 60.45ms -42.58% -16.68%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 27.70ms ± 0.10ms 26.50ms ± 0.81ms -4.32%
bench_hmr_to_eval/Turbopack CSR/1000 modules 24.83ms ± 1.16ms 31.56ms ± 4.27ms +27.09%
bench_startup/Turbopack CSR/1000 modules 5583.76ms ± 795.46ms 3205.98ms ± 60.45ms -42.58% -16.68%

jridgewell
jridgewell reviewed Jul 17, 2023
View reviewed changes
@kwonoj kwonoj force-pushed the feat-diag-type branch 2 times, most recently from 4ab2ad7 to 4f0984f Compare July 17, 2023 20:11
@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023

Linux Benchmark for 5b0bf11

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 5363.07µs ± 21.09µs 5381.32µs ± 27.92µs +0.34%
bench_hmr_to_eval/Turbopack CSR/1000 modules 5037.77µs ± 27.34µs 5014.65µs ± 27.76µs -0.46%
bench_startup/Turbopack CSR/1000 modules 805.72ms ± 1.13ms 804.69ms ± 1.92ms -0.13%

@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023

MacOS Benchmark for 5b0bf11

Test Base PR % Significant %
bench_startup/Turbopack CSR/1000 modules 3666.98ms ± 303.48ms 7241.53ms ± 1123.14ms +97.48% +16.88%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 27.12ms ± 0.08ms 27.44ms ± 0.24ms +1.19%
bench_hmr_to_eval/Turbopack CSR/1000 modules 25.90ms ± 1.02ms 26.10ms ± 1.03ms +0.79%
bench_startup/Turbopack CSR/1000 modules 3666.98ms ± 303.48ms 7241.53ms ± 1123.14ms +97.48% +16.88%

@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023

Windows Benchmark for 5b0bf11

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 15.82ms ± 0.05ms 15.56ms ± 0.01ms -1.64% -0.81%
bench_startup/Turbopack CSR/1000 modules 3706.68ms ± 8.34ms 3813.86ms ± 43.59ms +2.89% +0.09%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 15.82ms ± 0.05ms 15.56ms ± 0.01ms -1.64% -0.81%
bench_hmr_to_eval/Turbopack CSR/1000 modules 15.69ms ± 0.03ms 15.71ms ± 0.05ms +0.14%
bench_startup/Turbopack CSR/1000 modules 3706.68ms ± 8.34ms 3813.86ms ± 43.59ms +2.89% +0.09%

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2023

Linux Benchmark for ecf2e2d

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 5416.61µs ± 27.23µs 5388.09µs ± 23.08µs -0.53%
bench_hmr_to_eval/Turbopack CSR/1000 modules 5026.16µs ± 37.24µs 5156.68µs ± 126.36µs +2.60%
bench_startup/Turbopack CSR/1000 modules 809.79ms ± 0.75ms 809.39ms ± 1.70ms -0.05%

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2023

Linux Benchmark for 59140b8

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 5373.35µs ± 32.86µs 5414.72µs ± 25.09µs +0.77%
bench_hmr_to_eval/Turbopack CSR/1000 modules 5084.90µs ± 31.00µs 5421.95µs ± 341.35µs +6.63%
bench_startup/Turbopack CSR/1000 modules 805.72ms ± 1.36ms 808.47ms ± 3.63ms +0.34%

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2023

MacOS Benchmark for 59140b8

Test Base PR % Significant %
bench_startup/Turbopack CSR/1000 modules 4553.44ms ± 630.39ms 3147.30ms ± 64.12ms -30.88% -0.52%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 27.77ms ± 0.10ms 28.10ms ± 0.07ms +1.20%
bench_hmr_to_eval/Turbopack CSR/1000 modules 26.95ms ± 0.33ms 34.88ms ± 5.55ms +29.42%
bench_startup/Turbopack CSR/1000 modules 4553.44ms ± 630.39ms 3147.30ms ± 64.12ms -30.88% -0.52%

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2023

Linux Benchmark for 1f66ed7

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 5712.30µs ± 23.95µs 5720.04µs ± 62.52µs +0.14%
bench_hmr_to_eval/Turbopack CSR/1000 modules 5373.10µs ± 99.88µs 5421.93µs ± 158.08µs +0.91%
bench_startup/Turbopack CSR/1000 modules 817.15ms ± 1.12ms 819.19ms ± 2.98ms +0.25%

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2023

MacOS Benchmark for 1f66ed7

Test Base PR % Significant %
bench_hmr_to_eval/Turbopack CSR/1000 modules 26.05ms ± 0.17ms 26.62ms ± 0.10ms +2.22% +0.18%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 27.75ms ± 0.08ms 27.30ms ± 0.19ms -1.62%
bench_hmr_to_eval/Turbopack CSR/1000 modules 26.05ms ± 0.17ms 26.62ms ± 0.10ms +2.22% +0.18%
bench_startup/Turbopack CSR/1000 modules 6610.81ms ± 877.03ms 5291.03ms ± 933.10ms -19.96%

@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2023

Linux Benchmark for f98426c

Click to view benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 5470.15µs ± 23.04µs 5436.12µs ± 19.50µs -0.62%
bench_hmr_to_eval/Turbopack CSR/1000 modules 5111.42µs ± 21.17µs 5282.20µs ± 207.02µs +3.34%
bench_startup/Turbopack CSR/1000 modules 811.50ms ± 1.25ms 818.27ms ± 3.75ms +0.83%

@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2023

MacOS Benchmark for f98426c

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 27.57ms ± 0.06ms 26.96ms ± 0.17ms -2.21% -0.52%
bench_hmr_to_eval/Turbopack CSR/1000 modules 25.58ms ± 0.47ms 56.95ms ± 3.07ms +122.62% +91.55%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 27.57ms ± 0.06ms 26.96ms ± 0.17ms -2.21% -0.52%
bench_hmr_to_eval/Turbopack CSR/1000 modules 25.58ms ± 0.47ms 56.95ms ± 3.07ms +122.62% +91.55%
bench_startup/Turbopack CSR/1000 modules 3103.45ms ± 47.91ms 2994.48ms ± 103.67ms -3.51%

@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2023

Linux Benchmark for b928e8f

Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 6735.96µs ± 78.73µs 7232.74µs ± 145.05µs +7.38% +0.71%
bench_hmr_to_eval/Turbopack CSR/1000 modules 6265.78µs ± 81.68µs 6944.82µs ± 217.88µs +10.84% +1.24%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 6735.96µs ± 78.73µs 7232.74µs ± 145.05µs +7.38% +0.71%
bench_hmr_to_eval/Turbopack CSR/1000 modules 6265.78µs ± 81.68µs 6944.82µs ± 217.88µs +10.84% +1.24%
bench_startup/Turbopack CSR/1000 modules 833.05ms ± 2.25ms 835.07ms ± 5.05ms +0.24%

@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2023

MacOS Benchmark for b928e8f

Test Base PR % Significant %
bench_startup/Turbopack CSR/1000 modules 9399.44ms ± 1903.59ms 3328.14ms ± 53.54ms -64.59% -38.57%
Click to view full benchmark
Test Base PR % Significant %
bench_hmr_to_commit/Turbopack CSR/1000 modules 27.56ms ± 0.18ms 27.82ms ± 0.13ms +0.95%
bench_hmr_to_eval/Turbopack CSR/1000 modules 26.85ms ± 0.09ms 26.15ms ± 0.42ms -2.59%
bench_startup/Turbopack CSR/1000 modules 9399.44ms ± 1903.59ms 3328.14ms ± 53.54ms -64.59% -38.57%

@kwonoj kwonoj added the pr: automerge Kodiak will merge these automatically after checks pass label Jul 20, 2023
@kodiakhq kodiakhq bot merged commit 930fc4a into main Jul 20, 2023
@kodiakhq kodiakhq bot deleted the feat-diag-type branch July 20, 2023 19:03
@sokra sokra mentioned this pull request Jul 21, 2023
Merged
sokra added a commit to vercel/next.js that referenced this pull request Jul 21, 2023
@sokra @kodiakhq
update Turbopack (#52986)
e887772 
* vercel/turborepo#5567 <!-- Alex Kirszenberg -
Remove unnecessary ValueDebugFormat item, hide Vc field -->
* vercel/turborepo#5576 <!-- Alex Kirszenberg -
Extract shared HMR utils to their own modules/crates -->
* vercel/turborepo#5503 <!-- OJ Kwon -
feat(turbopack_core): define trait for diagnostics -->
* vercel/turborepo#5487 <!-- Will Binns-Smith -
turbopack-cli: modularize code to support turbopack build -->
* vercel/turborepo#5488 <!-- Will Binns-Smith -
turbopack-cli: implement `turbopack build` -->
* vercel/turborepo#5450 <!-- Leah - feat: async
modules / top level await -->

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@kwonoj
feat(turbopack_core): define trait for diagnostics (vercel/turborepo#…
e61cd6f 
…5503)

### Description

Extracting trait definition from
#52356, renamed it for more
generic usage that turbopack can emit any kind of arbitary metadata, but
next-swc can use it as telemetry for its subset.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@kwonoj
feat(turbopack_core): define trait for diagnostics (vercel/turborepo#…
0e758ab 
…5503)

### Description

Extracting trait definition from
#52356, renamed it for more
generic usage that turbopack can emit any kind of arbitary metadata, but
next-swc can use it as telemetry for its subset.
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@kwonoj
feat(turbopack_core): define trait for diagnostics (vercel/turborepo#…
6c6cceb 
…5503)

### Description

Extracting trait definition from
#52356, renamed it for more
generic usage that turbopack can emit any kind of arbitary metadata, but
next-swc can use it as telemetry for its subset.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jridgewell jridgewell jridgewell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr: automerge Kodiak will merge these automatically after checks pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kwonoj @jridgewell