Write the team ID to the repository config when a repo is linked to a Space #5561
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
| ) | ||
| })?; | ||
|
|
||
| fs::create_dir_all(base.repo_root.join_component(".turbo")) |
There was a problem hiding this comment.
@nathanhammond @gsoltis While testing, I discovered that link --target=spaces wasn't writing the selected team ID to .turbo/config.json. I ran into a situation where I had linked the repo for Remote Caching to another team and when I tried to enable Spaces, it wasn't generating any Runs data because it was trying to use the wrong team ID on subsequent requests.
I'm wondering what you recommend to do. We could ask the user if they want to override the team ID if the user tries to select a team that is different than the one that is already configured for the repository, we could show an error if the team ID that is already configured is different than the selected one, or we could store the team IDs for remote cache and spaces in separate fields. Thoughts?
🟢 CI successful 🟢Thanks |
Supersedes #5561 Write and use a configuration for a Spaces API client. It's not graceful, but allows for isolated configuration. Review ignoring whitespace: https://github.com/vercel/turbo/pull/5674/files?w=1 --------- Co-authored-by: Nathan Hammond <Nathan Hammond>
Description
This PR writes the team ID to the repository configuration file when a user links the repository to a Space so that that team ID will be used in future requests.
Testing Instructions
npx turbo loginnpx turbo link --target=spacesless .turbo/config.json