Stop hitting remote cache after a few failures #545
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/7ZZgsHnrn18J3mMabmEB9rcXpcDJ |
Apply review suggestions to remote failure PR
gsoltis
left a comment
There was a problem hiding this comment.
This looks like it's coming along.
One general Go comment to add: for methods or functions that are not intended to be used outside of a package, they can be kept private by starting the name with a lowercase letter. So IsProtocolExternal can be isProtocolExternal. Test code is typically part of the same package, so this does not impact the ability to write tests for this code.
Along those lines, it might be nice to have a quick test demonstrating some typical internal vs external references.
|
What's this in reference to @gsoltis ? |
|
Whoa, weird, that was a comment I made for a different PR authored via VSCode. I was wondering where it went... |
Close #541
When the remote cache fails or timesout more than
ntimes (twice at the moment),turbowill cease trying to hit the remote cache.