这是indexloc提供的服务，不要输入任何密码
Skip to content

fix: treat symlink directory as directory #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 10, 2022
Merged

fix: treat symlink directory as directory #532

merged 2 commits into from
Jan 10, 2022

Conversation

markjm
Copy link
Contributor

@markjm markjm commented Jan 10, 2022

Fixes #531

@markjm markjm requested a review from jaredpalmer as a code owner January 10, 2022 01:45
@vercel
Copy link

vercel bot commented Jan 10, 2022

@markjm is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

markjm
markjm commented Jan 10, 2022
View reviewed changes
cli/internal/fs/copy_file.go
},
Unsorted: true,
Unsorted: true,
AllowNonDirectory: true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This setting just does what the deleted compat code does already

markjm
markjm commented Jan 10, 2022
View reviewed changes
cli/internal/fs/copy_file.go
Unsorted: true,
Unsorted: true,
AllowNonDirectory: true,
FollowSymbolicLinks: false,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defaults to false anyway, but setting it explicitly, because some functionality depends on not following symlinks. For example, following symlinks in node_modules a yarn workspace will send you right back to the source code.

@vercel
Copy link

vercel bot commented Jan 10, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/turbo-site/2Lg15nUANcw4BcidCx8CwF3JSMLu
✅ Preview: https://turbo-site-git-fork-markjm-markjm-hash-bug.vercel.sh

@jaredpalmer jaredpalmer merged commit 8c871d4 into vercel:main Jan 10, 2022
@jaredpalmer
Copy link
Contributor

jaredpalmer commented Jan 17, 2022 •
edited
Loading

@markjm This is causing pnpm symlinks to become inconsistent/not be recognized (especially when user moves a folder). Reverting this change fixes the problem. Can you investigate #549?

Notice in screenshot how the apps are not recognized as result of globs?

CleanShot 2022-01-17 at 15 43 27@2x

CleanShot 2022-01-17 at 15 44 42@2x

@markjm
Copy link
Contributor Author

markjm commented Jan 17, 2022 •
edited
Loading

@markjm This is causing pnpm symlinks to become inconsistent/not be recognized (especially when user moves a folder). Reverting this change fixes the problem. Can you investigate #549?

Notice in screenshot how the apps are not recognized as result of globs?

CleanShot 2022-01-17 at 15 43 27@2x

CleanShot 2022-01-17 at 15 44 42@2x

Sure. In the meantime, it seems pnpm usage is more common than the frequency of the original bug I was trying to fix - so should probably just revert this for now.

I think I understand the gist of the issue, but I'm not at my computer til later today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpalmer jaredpalmer jaredpalmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error hashing files when globalDependencies contains a symlinked directory
2 participants
@markjm @jaredpalmer