feature(turborepo): Spaces gets its own API client. #5674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
Contributor
|
Someone is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
mknichel
approved these changes
Aug 5, 2023
Member
|
@nathanhammond Have you had a chance to talk to anyone else on the Turbo team about this PR? Is it ready to be reviewed? |
added 2 commits
August 14, 2023 17:31
de9bb00 to
782151b
Compare
NicholasLYang
approved these changes
Aug 17, 2023
Contributor
NicholasLYang
left a comment
There was a problem hiding this comment.
I don't have any objections to this! Run summary/spaces is probably gonna be ported soon so I'll probably do something similar on the Rust side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #5561
Write and use a configuration for a Spaces API client. It's not graceful, but allows for isolated configuration.
Review ignoring whitespace: https://github.com/vercel/turbo/pull/5674/files?w=1