fix CSS HMR #4815
Merged
fix CSS HMR #4815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
|
✅ This change can build |
alexkirsz
approved these changes
May 4, 2023
| @@ -77,9 +77,11 @@ let BACKEND; | |||
| reject(new Error("The DOM backend can only reload CSS chunks")); | |||
| return; | |||
| } | |||
|
|
|||
| const encodedChunkPath = encodeURIComponent(chunkPath).replace(/%2F/g, "/"); | |||
There was a problem hiding this comment.
Can't find where the reverse happens exactly, but we do the following for another case:
Suggested change
| const encodedChunkPath = encodeURIComponent(chunkPath).replace(/%2F/g, "/"); | |
| const encodedChunkPath = chunkPath.split("/").map(|component| encodeURIComponent(component)).join("/"); |
🟢 CI successful 🟢Thanks |
sokra
added a commit
to vercel/next.js
that referenced
this pull request
May 4, 2023
* vercel/turborepo#4815 <!-- Tobias Koppers - fix CSS HMR --> --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
gsoltis
pushed a commit
that referenced
this pull request
May 5, 2023
### Description * type=stylesheet => rel=stylesheet * remove timestamp, that's not needed * ensure correct encoding of the href
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description * type=stylesheet => rel=stylesheet * remove timestamp, that's not needed * ensure correct encoding of the href
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description * type=stylesheet => rel=stylesheet * remove timestamp, that's not needed * ensure correct encoding of the href
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description * type=stylesheet => rel=stylesheet * remove timestamp, that's not needed * ensure correct encoding of the href
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description