这是indexloc提供的服务,不要输入任何密码
Skip to content

Print a warning when importing Sass files #4789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2023

Conversation

alexkirsz
Copy link
Contributor

@alexkirsz alexkirsz commented May 3, 2023

Description

image

Testing Instructions

See Next.js PR

link WEB-981

@alexkirsz alexkirsz requested a review from a team as a code owner May 3, 2023 14:13
@vercel
Copy link

vercel bot commented May 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web 🔄 Building (Inspect) May 3, 2023 3:01pm
examples-native-web 🔄 Building (Inspect) May 3, 2023 3:01pm
examples-svelte-web 🔄 Building (Inspect) May 3, 2023 3:01pm
examples-vite-web 🔄 Building (Inspect) May 3, 2023 3:01pm
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-cra-web ⬜️ Ignored (Inspect) May 3, 2023 3:01pm
examples-designsystem-docs ⬜️ Ignored (Inspect) May 3, 2023 3:01pm
examples-gatsby-web ⬜️ Ignored (Inspect) May 3, 2023 3:01pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) May 3, 2023 3:01pm
examples-nonmonorepo ⬜️ Ignored (Inspect) May 3, 2023 3:01pm
examples-tailwind-web ⬜️ Ignored (Inspect) May 3, 2023 3:01pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview May 3, 2023 3:01pm

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

✅ This change can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

🟢 CI successful 🟢

Thanks

@sokra sokra merged commit 91c1bbb into main May 3, 2023
@sokra sokra deleted the alexkirsz/web-981-print-a-warning-when-importing-sass branch May 3, 2023 15:36
alexkirsz added a commit to vercel/next.js that referenced this pull request May 3, 2023
See vercel/turborepo#4776

This adds support for:

* Default and custom global app 404 pages (`app/not-found`).
* Segment-level 404 pages (`app/segment/not-found`).

This also updates Turbopack:

* vercel/turborepo#4787 <!-- Tobias Koppers -
Bugfixes for free var and binding replacement -->
* vercel/turborepo#4789 <!-- Alex Kirszenberg -
Print a warning when importing Sass files -->
* vercel/turborepo#4776 <!-- Alex Kirszenberg -
Leave pathname formatting up to the caller -->
* vercel/turborepo#4790 <!-- Tobias Koppers - remove
inital compilation message by default -->

## TODO:

- [ ] ~~The dev overlay shows up when `notFound()` is called, it should
be hidden~~ (moved to WEB-980)
- [ ] ~~Navigating to the global 404 page doesn't work~~ (this is a bug
in Next.js, see NEXT-963)
- [x] Tests.

---------

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request May 3, 2023
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants