Match TS's extends resolution algorithm #4754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
|
✅ This change can build |
🟢 CI successful 🟢Thanks |
6ba43e7 to
a397b6f
Compare
alexkirsz
approved these changes
May 1, 2023
sokra
reviewed
May 1, 2023
sokra
approved these changes
May 1, 2023
Co-authored-by: Alex Kirszenberg <alex.kirszenberg@vercel.com>
sokra
added a commit
to vercel/next.js
that referenced
this pull request
May 1, 2023
See vercel/turborepo#4598 ### Turbopack changes * vercel/turborepo#4754 <!-- Justin Ridgewell - Match TS's extends resolution algorithm --> * vercel/turborepo#4598 <!-- Alex Kirszenberg - More fluent GraphTraversal API --> --------- Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
sokra
pushed a commit
that referenced
this pull request
May 2, 2023
In #4754, I screwed up the resolution logic for configs that reference another config inside a node module. In it, I incorrectly joined `/tsconfig.json` before performing any lookup, because I thought the joining was happening in the `combinePaths` in https://github.com/microsoft/TypeScript/blob/611a912d/src/compiler/commandLineParser.ts#L3315. But, that combine has no real affect, it immediately gets stripped in a call to `getDirectoryPath` in https://github.com/microsoft/TypeScript/blob/611a912d/src/compiler/moduleNameResolver.ts#LL1703C93-L1703. Instead, it performs a basic `node_module` lookup using the input module name, and even tries to load the file referenced at that location (eg, it's a `extends: 'foo/tsconfig.json'`). If that fails, then it combines with an implied `/tsconfig` the same way a `/index` is appended when doing `require('./directory')`. Fixes WEB-974
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description Implements TS's `extends` [resolution algorithm](https://github.com/microsoft/TypeScript/blob/611a912d/src/compiler/commandLineParser.ts#L3294-L3326). In particular, there are a few cases that need to be properly handled: - Relative paths: if the file doesn't exist and the path doesn't end in `.json`, try again with `.json` extension - Windows paths: same thing - Posix paths: same thing - `.` and `..` (but not `./` nor `../` because they're relative paths): join with `/tsconfig.json` before looking up - `foo` module import: join with `/tsconfig.json` before looking up ### Testing Instructions Snapshot tests Fixes WEB-963 fix vercel/turborepo#2682 --------- Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com> Co-authored-by: Alex Kirszenberg <alex.kirszenberg@vercel.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description Implements TS's `extends` [resolution algorithm](https://github.com/microsoft/TypeScript/blob/611a912d/src/compiler/commandLineParser.ts#L3294-L3326). In particular, there are a few cases that need to be properly handled: - Relative paths: if the file doesn't exist and the path doesn't end in `.json`, try again with `.json` extension - Windows paths: same thing - Posix paths: same thing - `.` and `..` (but not `./` nor `../` because they're relative paths): join with `/tsconfig.json` before looking up - `foo` module import: join with `/tsconfig.json` before looking up ### Testing Instructions Snapshot tests Fixes WEB-963 fix vercel/turborepo#2682 --------- Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com> Co-authored-by: Alex Kirszenberg <alex.kirszenberg@vercel.com>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description Implements TS's `extends` [resolution algorithm](https://github.com/microsoft/TypeScript/blob/611a912d/src/compiler/commandLineParser.ts#L3294-L3326). In particular, there are a few cases that need to be properly handled: - Relative paths: if the file doesn't exist and the path doesn't end in `.json`, try again with `.json` extension - Windows paths: same thing - Posix paths: same thing - `.` and `..` (but not `./` nor `../` because they're relative paths): join with `/tsconfig.json` before looking up - `foo` module import: join with `/tsconfig.json` before looking up ### Testing Instructions Snapshot tests Fixes WEB-963 fix vercel/turborepo#2682 --------- Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com> Co-authored-by: Alex Kirszenberg <alex.kirszenberg@vercel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements TS's
extendsresolution algorithm. In particular, there are a few cases that need to be properly handled:.json, try again with.jsonextension.and..(but not./nor../because they're relative paths): join with/tsconfig.jsonbefore looking upfoomodule import: join with/tsconfig.jsonbefore looking upTesting Instructions
Snapshot tests
Fixes WEB-963
fix #2682