docs: fix typo in migrate-from-lerna.mdx #457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/HSKeHzwM9pUBXqF8JuphzSjq7XcY |
sokra
pushed a commit
that referenced
this pull request
Oct 25, 2022
Closes #440 This uses swc's preset_env to automatically downlevel code according to the environment's browser targets, and sets next-dev to use a limited, modern target. To do: * [x] Add snapshot test * [x] turbotrace test failures — looks like this has something to do with the Buffer module? Hitting swc's "multiple constructors" not implemented: https://github.com/swc-project/swc/blob/f655488cfa252e68d8d2c0c01b398d84acc73191/crates/swc_ecma_transforms_compat/src/es2015/classes/mod.rs#L545 * [x] ~Benchmark downleveling node_modules (probably on front) and make a decision re: downleveling everything vs. just workspaces~ Filed as #457
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
…l/turborepo#380) Closes vercel/turborepo#440 This uses swc's preset_env to automatically downlevel code according to the environment's browser targets, and sets next-dev to use a limited, modern target. To do: * [x] Add snapshot test * [x] turbotrace test failures — looks like this has something to do with the Buffer module? Hitting swc's "multiple constructors" not implemented: https://github.com/swc-project/swc/blob/f655488cfa252e68d8d2c0c01b398d84acc73191/crates/swc_ecma_transforms_compat/src/es2015/classes/mod.rs#L545 * [x] ~Benchmark downleveling node_modules (probably on front) and make a decision re: downleveling everything vs. just workspaces~ Filed as vercel/turborepo#457
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
…l/turborepo#380) Closes vercel/turborepo#440 This uses swc's preset_env to automatically downlevel code according to the environment's browser targets, and sets next-dev to use a limited, modern target. To do: * [x] Add snapshot test * [x] turbotrace test failures — looks like this has something to do with the Buffer module? Hitting swc's "multiple constructors" not implemented: https://github.com/swc-project/swc/blob/f655488cfa252e68d8d2c0c01b398d84acc73191/crates/swc_ecma_transforms_compat/src/es2015/classes/mod.rs#L545 * [x] ~Benchmark downleveling node_modules (probably on front) and make a decision re: downleveling everything vs. just workspaces~ Filed as vercel/turborepo#457
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes an extra "using" in the docs