这是indexloc提供的服务，不要输入任何密码
Skip to content

Use pnpm in prepare script #4466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2023
Merged

Use pnpm in prepare script #4466

merged 1 commit into from
Apr 5, 2023

Conversation

@mehulkar
Copy link
Contributor

@mehulkar mehulkar commented Apr 5, 2023

Corepack throws an error when running pnpm install from the root of the monorepo, because the prepare script is run when you run install. Corepack does not allow using npm, because the root of the monorepo
has configured the packageManager to be pnpm.

@mehulkar
Use pnpm in prepare script
ad655a7 
Corepack throws an error when running pnpm install
from the root of the monorepo, because the prepare
script is run when you run install. Corepack does not
allow using npm, because the root of the monorepo
has configured the packageManager to be pnpm.
@mehulkar mehulkar requested review from a team as code owners April 5, 2023 00:00
@vercel
Copy link
Contributor

vercel bot commented Apr 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-cra-web 🔄 Building (Inspect) Apr 5, 2023 0:01am
turbo-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2023 0:01am
9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Apr 5, 2023 0:01am
examples-designsystem-docs ⬜️ Ignored (Inspect) Apr 5, 2023 0:01am
examples-gatsby-web ⬜️ Ignored (Inspect) Apr 5, 2023 0:01am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Apr 5, 2023 0:01am
examples-native-web ⬜️ Ignored (Inspect) Apr 5, 2023 0:01am
examples-nonmonorepo ⬜️ Ignored (Inspect) Apr 5, 2023 0:01am
examples-svelte-web ⬜️ Ignored (Inspect) Apr 5, 2023 0:01am
examples-tailwind-web ⬜️ Ignored (Inspect) Apr 5, 2023 0:01am
examples-vite-web ⬜️ Ignored (Inspect) Apr 5, 2023 0:01am

@mehulkar mehulkar enabled auto-merge (squash) April 5, 2023 00:01
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

This changes may fail to build next-swc.

info: syncing channel updates for 'nightly-2023-03-09-x86_64-unknown-linux-gnu'
info: latest update on 2023-03-09, rust version 1.70.0-nightly (900c35403 2023-03-08)
info: downloading component 'cargo'
info: downloading component 'rust-std'
info: downloading component 'rustc'
info: installing component 'cargo'
info: installing component 'rust-std'
info: installing component 'rustc'
crates/next-core/src/next_client/runtime_entry.rs:13:13: error[E0432]: unresolved import `turbo_binding::turbopack::ecmascript::process_runtime_entries`
crates/next-core/src/next_client_chunks/with_chunks.rs:10:41: error[E0432]: unresolved import `turbo_binding::turbopack::core::chunk::ChunkListReferenceVc`
crates/next-core/src/app_source.rs:463:18: error[E0061]: this function takes 8 arguments but 9 arguments were supplied
crates/next-core/src/app_source.rs:504:18: error[E0061]: this function takes 7 arguments but 8 arguments were supplied
crates/next-core/src/app_source.rs:706:13: error[E0560]: struct `NodeRenderingEntry` has no field named `context`
crates/next-core/src/app_source.rs:787:13: error[E0560]: struct `NodeRenderingEntry` has no field named `context`
crates/next-core/src/fallback.rs:86:24: error[E0599]: no method named `as_evaluated_chunk` found for struct `EcmascriptModuleAssetVc` in the current scope
crates/next-core/src/fallback.rs:90:14: error[E0061]: this function takes 2 arguments but 1 argument was supplied
crates/next-core/src/next_client/transition.rs:113:35: error[E0308]: mismatched types
crates/next-core/src/next_client_chunks/with_chunks.rs:142:37: error[E0599]: no method named `chunk_list_path` found for struct `ChunkGroupVc` in the current scope
crates/next-core/src/next_client_chunks/with_chunks.rs:149:51: error[E0599]: the method `path` exists for reference `&AssetVc`, but its trait bounds were not satisfied
crates/next-core/src/next_client_component/with_client_chunks.rs:143:36: error[E0599]: the method `path` exists for reference `&AssetVc`, but its trait bounds were not satisfied
crates/next-core/src/page_loader.rs:104:44: error[E0599]: no method named `as_evaluated_chunk` found for struct `EcmascriptModuleAssetVc` in the current scope
crates/next-core/src/page_loader.rs:104:13: error[E0061]: this function takes 2 arguments but 1 argument was supplied
crates/next-core/src/page_loader.rs:106:12: error[E0308]: mismatched types
crates/next-core/src/page_source.rs:368:9: error[E0061]: this function takes 7 arguments but 8 arguments were supplied
crates/next-core/src/page_source.rs:418:13: error[E0061]: this function takes 8 arguments but 9 arguments were supplied
crates/next-core/src/page_source.rs:429:13: error[E0061]: this function takes 8 arguments but 9 arguments were supplied
crates/next-core/src/page_source.rs:542:9: error[E0061]: this function takes 8 arguments but 9 arguments were supplied
crates/next-core/src/page_source.rs:737:13: error[E0560]: struct `NodeRenderingEntry` has no field named `context`
crates/next-core/src/web_entry_source.rs:150:40: error[E0599]: no method named `as_evaluated_chunk` found for struct `EcmascriptModuleAssetVc` in the current scope
crates/next-core/src/web_entry_source.rs:151:35: error[E0061]: this function takes 2 arguments but 1 argument was supplied
crates/next-core/src/web_entry_source.rs:156:20: error[E0061]: this function takes 2 arguments but 1 argument was supplied
crates/next-core/src/next_client_chunks/with_chunks.rs:9:54: warning: unused import: `Chunk`
crates/next-core/src/next_client_chunks/with_chunks.rs:4:13: warning: unused import: `tasks::TryJoinIterExt`
crates/next-core/src/next_client_component/with_client_chunks.rs:9:54: warning: unused import: `Chunk`
error: could not compile `next-core` (lib) due to 23 previous errors; 3 warnings emitted

@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023 •
edited
Loading

🟢 CI successful 🟢

Thanks

@mehulkar mehulkar merged commit 2a52a58 into main Apr 5, 2023
@mehulkar mehulkar deleted the mehulkar-patch-1 branch April 5, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tknickman tknickman tknickman approved these changes

@nathanhammond nathanhammond Awaiting requested review from nathanhammond nathanhammond is a code owner automatically assigned from vercel/turbo-oss

@NicholasLYang NicholasLYang Awaiting requested review from NicholasLYang NicholasLYang is a code owner automatically assigned from vercel/turbo-oss

Assignees

No one assigned

Labels

area: ci

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mehulkar @tknickman