feat(ecmascript): support configurable emotion options #4458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
🟢 CI successful 🟢Thanks |
66190bc to
814cfea
Compare
f9e1571 to
fd14bd5
Compare
|
✅ This changes can build |
fd14bd5 to
1f88f0e
Compare
jridgewell
reviewed
Apr 5, 2023
| Emotion, | ||
| Emotion { | ||
| #[serde(default)] | ||
| sourcemap: bool, |
There was a problem hiding this comment.
Can we just always enable the sourcemap?
There was a problem hiding this comment.
for now, this inherits what next.config.js allow to configure. I hope to simplify / consolidate but thinking about feature parity to existing next.js configs we may need to expose.
| #[turbo_tasks::value(shared)] | ||
| #[derive(Default, Clone, Debug)] | ||
| pub struct EmotionTransformOptions { | ||
| pub enabled: bool, |
There was a problem hiding this comment.
Do we need an enabled if the enable_emotion if this is only used inside an Option wrapper? Shouldn't the Some(EmotionTransformOptions) imply that it is enabled?
There was a problem hiding this comment.
That's how I started, and then ends up this was somewhat more ergonomics when try to read next.config.js, we have couple of conditions
- if compiler option non-exists - None
- if exists, somehow user configures
emotion: falseoremotion: {enabled :false}
and having Option was easier to gracefully read & create config value among those conditions. It is possible to argue who would do 2 (if you specifiy compiler option, explicitly disabling it is non common) but that's certainly possible case if someone relies on some dynamic evaluation based on env / fn.
1f88f0e to
3ce7565
Compare
jridgewell
approved these changes
Apr 5, 2023
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Apr 5, 2023
### Description Related with WEB-669. PR implements initial path to configuring emotion transforms. It doesn't fully implement all of the options values though -`auto-label` have different values between next.config.js to the swc's actual transform options, as well as `importMap`. These will be gradually follow up since it is not an immediate blocker for the feature itself.
sokra
pushed a commit
that referenced
this pull request
Apr 5, 2023
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…epo#4458) ### Description Related with WEB-669. PR implements initial path to configuring emotion transforms. It doesn't fully implement all of the options values though -`auto-label` have different values between next.config.js to the swc's actual transform options, as well as `importMap`. These will be gradually follow up since it is not an immediate blocker for the feature itself.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…epo#4458) ### Description Related with WEB-669. PR implements initial path to configuring emotion transforms. It doesn't fully implement all of the options values though -`auto-label` have different values between next.config.js to the swc's actual transform options, as well as `importMap`. These will be gradually follow up since it is not an immediate blocker for the feature itself.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…epo#4458) ### Description Related with WEB-669. PR implements initial path to configuring emotion transforms. It doesn't fully implement all of the options values though -`auto-label` have different values between next.config.js to the swc's actual transform options, as well as `importMap`. These will be gradually follow up since it is not an immediate blocker for the feature itself.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related with WEB-669.
PR implements initial path to configuring emotion transforms. It doesn't fully implement all of the options values though -
auto-labelhave different values between next.config.js to the swc's actual transform options, as well asimportMap. These will be gradually follow up since it is not an immediate blocker for the feature itself.