Use SharedError for body streaming
#4392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 11 Ignored Deployments
|
kwonoj
approved these changes
Mar 29, 2023
|
✅ This changes can build |
🟢 CI successful 🟢Thanks |
sokra
approved these changes
Mar 31, 2023
Comment on lines
+60
to
+85
| impl Serialize for SharedError { | ||
| fn serialize<S: Serializer>(&self, serializer: S) -> Result<S::Ok, S::Error> { | ||
| let mut v = vec![self.to_string()]; | ||
| let mut source = self.source(); | ||
| while let Some(s) = source { | ||
| v.push(s.to_string()); | ||
| source = s.source(); | ||
| } | ||
| Serialize::serialize(&v, serializer) | ||
| } | ||
| } | ||
|
|
||
| impl<'de> Deserialize<'de> for SharedError { | ||
| fn deserialize<D: Deserializer<'de>>(deserializer: D) -> Result<Self, D::Error> { | ||
| use serde::de::Error; | ||
| let mut messages = <Vec<String>>::deserialize(deserializer)?; | ||
| let mut e = match messages.pop() { | ||
| Some(e) => anyhow!(e), | ||
| None => return Err(Error::custom("expected at least 1 error message")), | ||
| }; | ||
| while let Some(message) = messages.pop() { | ||
| e = e.context(message); | ||
| } | ||
| Ok(SharedError::new(e)) | ||
| } | ||
| } |
There was a problem hiding this comment.
Not sure if this is a good idea. It's not perfectly restoring error types. Maybe we should return an Serialization error when there is an non-anyhow error in the chain.
There was a problem hiding this comment.
Does it matter? The first value is guaranteed to be an anyhow::Error, and the sources are only guaranteed to be dyn std::error::Error implementors. I'm not sure how to even observe that the real struct changes between serialization and deserialization.
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Apr 1, 2023
Pending vercel/turborepo#4392 landing in Turbopack (and #47476 landing here), this removes `BodyError` and switches to `SharedError`. That should allow us to preserve the source chain of errors for when we finally display it to the dev, aiding debugging.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
Follow up to vercel/turborepo#4329, this removes `BodyError` (which was just a simple `String` and not an `Error`) and switches to `SharedError`. I've implemented a basic `PartialEq` and `Serialization` for `SharedError` so that it doesn't infect everything that uses `Body`.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
Follow up to vercel/turborepo#4329, this removes `BodyError` (which was just a simple `String` and not an `Error`) and switches to `SharedError`. I've implemented a basic `PartialEq` and `Serialization` for `SharedError` so that it doesn't infect everything that uses `Body`.
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
Follow up to vercel/turborepo#4329, this removes `BodyError` (which was just a simple `String` and not an `Error`) and switches to `SharedError`. I've implemented a basic `PartialEq` and `Serialization` for `SharedError` so that it doesn't infect everything that uses `Body`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #4329, this removes
BodyError(which was just a simpleStringand not anError) and switches toSharedError.I've implemented a basic
PartialEqandSerializationforSharedErrorso that it doesn't infect everything that usesBody.