refactor(turborepo): Factored out API Client crate #4388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
|
@NicholasLYang is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
NicholasLYang
commented
Mar 29, 2023
| let client = match timeout { | ||
| Some(timeout) => reqwest::Client::builder() | ||
| .timeout(std::time::Duration::from_secs(timeout)) | ||
| .build()?, | ||
| None => reqwest::Client::builder().build()?, | ||
| }; | ||
|
|
||
| let user_agent = format!( |
There was a problem hiding this comment.
We make user_agent a field in APIClient so that turborepo-lib can pass the version info instead of having turborepo-api-client have a dependency on get_version. That way we don't have to share get_version between turborepo-api-client and turborepo-lib.
There was a problem hiding this comment.
I think that is a good choice.
5b7863e to
bd35500
Compare
arlyon
approved these changes
Mar 31, 2023
3ab2d6d to
5a5166c
Compare
a11f858 to
0787f09
Compare
mehulkar
reviewed
Apr 4, 2023
…tp cache can use client without importing all of turborepo-lib
…nt workflow/codeowners files
16a692d to
b9443e4
Compare
sokra
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Factored out the API client into a separate crate so that we can use the API client without importing all of turborepo-lib. Also makes turborepo-lib less monolithic.
Testing Instructions