Refactor log streaming #462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/vercel/turbo-site/GW7eJaZrmhfqnrdbGd15wDyUxiof |
sokra
added a commit
that referenced
this pull request
Oct 25, 2022
make ProcessEnv a trait to allow other implemenetations of it
jridgewell
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 10, 2023
make ProcessEnv a trait to allow other implemenetations of it
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
make ProcessEnv a trait to allow other implemenetations of it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #422 #374 #452 #453
io.MultiReaderwhich was trying to concatenate streams, and failing when commands wrote directly to stderr. This PR inverts log steam logic to useio.MultiWriter, but only when actually caching, as well as newlogstreamerprimitive.cache hit, replaying output [hash]lineThe result of the last 3 bullets are a small perf gain since there is less work to be done when reading logs (colored prefixing isn't cheap).