update next.js to 13.1.7-canary.2 #3595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
Benchmark for 2737e22
Click to view full benchmark
|
Benchmark for 4575549
Click to view full benchmark
|
|
Benchmark for 274e657
Click to view full benchmark
|
e309999 to
af163d1
Compare
Benchmark for 339f58d
Click to view full benchmark
|
sokra
commented
Feb 2, 2023
| NpmPackage::new("next", "13.0.8-canary.2"), | ||
| NpmPackage::new("next", "13.1.7-canary.2"), |
There was a problem hiding this comment.
This enables the next.js router for the benchmarks, which causes a slowdown
There was a problem hiding this comment.
Would be nice if we could declare this in some central place somehow
sokra
commented
Feb 2, 2023
Comment on lines
+163
to
+164
| let globs = cwd.join(globs.replace('/', PATH_SEP.to_string().as_str())); | ||
| let root = cwd.join(root.replace('/', PATH_SEP.to_string().as_str())); |
sokra
commented
Feb 2, 2023
| let mut seen = HashSet::from([cwd.join(root)]); | ||
| let globs = cwd.join(globs.replace('/', PATH_SEP.to_string().as_str())); | ||
| let root = cwd.join(root.replace('/', PATH_SEP.to_string().as_str())); | ||
| println!("cargo:rerun-if-changed={}", root.display()); |
There was a problem hiding this comment.
The root directory should also be watched
alexkirsz
approved these changes
Feb 2, 2023
| let mut seen = HashSet::from([cwd.join(root)]); | ||
| let globs = cwd.join(globs.replace('/', PATH_SEP.to_string().as_str())); | ||
| let root = cwd.join(root.replace('/', PATH_SEP.to_string().as_str())); | ||
| println!("cargo:rerun-if-changed={}", root.display()); |
There was a problem hiding this comment.
Shouldn't that be handled by the ancestors iter below? Or is that for the case where root is empty?
There was a problem hiding this comment.
The root is in seen from the beginning, so it's ignored below
ForsakenHarmony
approved these changes
Feb 2, 2023
| GlobVc::new( | ||
| "**/*/next/dist/client/components/react-dev-overlay/hot-reloader-client.js", | ||
| ), | ||
| GlobVc::new("**/next/dist/client/components/react-dev-overlay/hot-reloader-client.js"), |
There was a problem hiding this comment.
locally rustfmt does this differently for me
There was a problem hiding this comment.
The CI checks fmt, so it's fine^^
sokra
added a commit
to vercel/next.js
that referenced
this pull request
Mar 13, 2023
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.